Add Support for Additional Printer Columns #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are now supporting the additionalPrinterColumn field from CRDs, so that we can show the specified columns within a List of CRs and in the details view of a CR.
We forgot to add the Keychain Sharing capability, so that the users settings and bookmarks were not saved on macOS. The capability is added now so that the app settings and bookmarks are saved properly.
This reverts commit 989d74b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are now supporting the additionalPrinterColumn field from CRDs, so that we can show the specified columns within a List of CRs and in the details view of a CR.
We forgot to add the Keychain Sharing capability, so that the users settings and bookmarks were not saved on macOS. The capability is added now so that the app settings and bookmarks are saved properly.