Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drain timeout #78

Closed
sylr opened this issue Jun 18, 2019 · 7 comments
Closed

Drain timeout #78

sylr opened this issue Jun 18, 2019 · 7 comments

Comments

@sylr
Copy link

sylr commented Jun 18, 2019

It would be great to be able to define a timeout for pod eviction.

If drain did not succeed within the timeout kured would stop trying to evict pods and release the lock.

This would be handy when pod disruption budgets does not allow eviction.

Regards.

@sylr sylr changed the title Eviction timeout Drain timeout Jun 18, 2019
@sylr sylr mentioned this issue Jun 18, 2019
@github-actions
Copy link

This issue was automatically considered stale due to lack of activity. Please update it and/or join our slack channels to promote it, before it automatically closes (in 7 days).

@bboreham
Copy link
Contributor

Still valid

@bboreham bboreham reopened this Dec 22, 2020
@bboreham
Copy link
Contributor

Is it possible to detect the difference between "drain is taking a long time" and "drain will never happen because of pod disruption budget" ?

@flbla
Copy link

flbla commented Dec 29, 2020

#283

@matthiasritter
Copy link

We'd love to see this implemented too :-)
Will this be merged?

@github-actions
Copy link

This issue was automatically considered stale due to lack of activity. Please update it and/or join our slack channels to promote it, before it automatically closes (in 7 days).

@evrardjp
Copy link
Collaborator

evrardjp commented Apr 14, 2021

@flbla @sylr could you have a look at #341 ? I think the current implementation is covering your case.
However, if it's not, don't hesitate to highlight what we are missing! :)

FYI, there is also this issue you might be interested with: #303

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants