Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invalid project ID in API requests for Nutanix provider #6572

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Fix invalid project ID in API requests for Nutanix provider #6572

merged 1 commit into from
Mar 4, 2024

Conversation

Waseem826
Copy link
Contributor

What this PR does / why we need it:
Fix invalid project ID in API requests for Nutanix provider.

Which issue(s) this PR fixes:

Fixes #6571

What type of PR is this?

/kind bug

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

Fix invalid project ID in API requests for Nutanix provider.

Documentation:

NONE

@Waseem826 Waseem826 added this to the KKP 2.25 milestone Mar 4, 2024
@kubermatic-bot kubermatic-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. docs/none Denotes a PR that doesn't need documentation (changes). kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. do-not-merge/code-freeze Indicates that a PR should not merge because it has not been approved for code freeze yet. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 4, 2024
@Waseem826 Waseem826 marked this pull request as draft March 4, 2024 08:23
@Waseem826 Waseem826 marked this pull request as ready for review March 4, 2024 09:57
@Waseem826 Waseem826 changed the title [WIP] ~ Fix invalid project ID in API requests for Nutanix provider Fix invalid project ID in API requests for Nutanix provider Mar 4, 2024
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 4, 2024
@Waseem826
Copy link
Contributor Author

/cherrypick release/v2.24

@kubermatic-bot
Copy link
Contributor

@Waseem826: once the present PR merges, I will cherry-pick it on top of release/v2.24 in a new PR and assign it to you.

In response to this:

/cherrypick release/v2.24

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Waseem826
Copy link
Contributor Author

/cherrypick release/v2.23

@kubermatic-bot
Copy link
Contributor

@Waseem826: once the present PR merges, I will cherry-pick it on top of release/v2.23 in a new PR and assign it to you.

In response to this:

/cherrypick release/v2.23

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Waseem826
Copy link
Contributor Author

/cherrypick release/v2.22

@kubermatic-bot
Copy link
Contributor

@Waseem826: once the present PR merges, I will cherry-pick it on top of release/v2.22 in a new PR and assign it to you.

In response to this:

/cherrypick release/v2.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ahmedwaleedmalik
ahmedwaleedmalik approved these changes Mar 4, 2024
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 4, 2024
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 49d73cada85b19b7c40233953facb08dc39f15d2

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2024
@Waseem826
Copy link
Contributor Author

/retest

@Waseem826 Waseem826 added the code-freeze-approved Indicates a PR has been approved by release managers during code freeze. label Mar 4, 2024
@kubermatic-bot kubermatic-bot removed the do-not-merge/code-freeze Indicates that a PR should not merge because it has not been approved for code freeze yet. label Mar 4, 2024
@kubermatic-bot kubermatic-bot merged commit 509587c into kubermatic:main Mar 4, 2024
9 of 10 checks passed
@kubermatic-bot
Copy link
Contributor

@Waseem826: new pull request created: #6573

In response to this:

/cherrypick release/v2.23

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot kubermatic-bot mentioned this pull request Mar 4, 2024
Merged
@kubermatic-bot
Copy link
Contributor

@Waseem826: new pull request created: #6574

In response to this:

/cherrypick release/v2.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot kubermatic-bot mentioned this pull request Mar 4, 2024
Merged
@kubermatic-bot
Copy link
Contributor

@Waseem826: new pull request created: #6575

In response to this:

/cherrypick release/v2.24

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot kubermatic-bot mentioned this pull request Mar 4, 2024
Merged
@Waseem826 Waseem826 deleted the 6571-invalid-project-id-nutanix branch March 6, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedwaleedmalik ahmedwaleedmalik ahmedwaleedmalik approved these changes

Assignees

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. code-freeze-approved Indicates a PR has been approved by release managers during code freeze. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
KKP 2.25
Development

Successfully merging this pull request may close these issues.

Dashboard queries incorrect URL for Nutanix cluster
3 participants
@Waseem826 @kubermatic-bot @ahmedwaleedmalik