-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor corrections to Master/Seed MLA stack docs #1653
Conversation
095aeb0
to
e0f3da6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are some good changes, but since we are already touching this documentation ... Thanos support was removed almost two years ago: kubermatic/kubermatic#11424. Can you maybe update this page to remove the references to Thanos?
Signed-off-by: archups <archupsawant@gmail.com>
Signed-off-by: archups <archupsawant@gmail.com>
e0f3da6
to
78924f9
Compare
done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Thank you!
LGTM label has been added. Git tree hash: 9a4f0201ef58fb3070682958eb74e33f3d626ac3
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: embik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR is to make some minor updates to the Master/seed monitoring, logging and alerting docs. Plus removed the Thanos support documentation as per kubermatic/kubermatic#11424