Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor corrections to Master/Seed MLA stack docs #1653

Merged
merged 2 commits into from
Jul 23, 2024

Conversation

archups
Copy link
Contributor

@archups archups commented Mar 19, 2024

This PR is to make some minor updates to the Master/seed monitoring, logging and alerting docs. Plus removed the Thanos support documentation as per kubermatic/kubermatic#11424

@kubermatic-bot kubermatic-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Mar 19, 2024
@archups archups self-assigned this Mar 19, 2024
@kubermatic-bot kubermatic-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 19, 2024
@archups archups changed the title WIP: Minor corrections to Master/Seed MLA stack docs Minor corrections to Master/Seed MLA stack docs Jul 16, 2024
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 16, 2024
@archups archups requested review from embik and removed request for embik July 16, 2024 18:37
@archups archups changed the title Minor corrections to Master/Seed MLA stack docs WIP: Minor corrections to Master/Seed MLA stack docs Jul 16, 2024
@kubermatic-bot kubermatic-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 16, 2024
Copy link
Member

@embik embik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are some good changes, but since we are already touching this documentation ... Thanos support was removed almost two years ago: kubermatic/kubermatic#11424. Can you maybe update this page to remove the references to Thanos?

Signed-off-by: archups <archupsawant@gmail.com>
Signed-off-by: archups <archupsawant@gmail.com>
@kubermatic-bot kubermatic-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 22, 2024
@archups archups changed the title WIP: Minor corrections to Master/Seed MLA stack docs Minor corrections to Master/Seed MLA stack docs Jul 22, 2024
@archups archups requested a review from embik July 22, 2024 19:03
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 22, 2024
@archups
Copy link
Contributor Author

archups commented Jul 22, 2024

These are some good changes, but since we are already touching this documentation ... Thanos support was removed almost two years ago: kubermatic/kubermatic#11424. Can you maybe update this page to remove the references to Thanos?

done!

@archups archups requested a review from xrstf July 22, 2024 19:04
Copy link
Member

@embik embik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Thank you!

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 23, 2024
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9a4f0201ef58fb3070682958eb74e33f3d626ac3

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: embik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 23, 2024
@kubermatic-bot kubermatic-bot merged commit 9c0a34a into kubermatic:main Jul 23, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants