azure-terraform: allow nodeports #1528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubermatic-bot
added
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kron4eg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubermatic-bot
added
approved
Signed-off-by: Artiom Diomin <kron82@gmail.com>
kron4eg
force-pushed
the
azure-sg-nodeports
branch
from
5979f68
to
cc1cb9d
Compare
kubermatic-bot
removed
the
do-not-merge/work-in-progress
|
/retest |
xmudrii
reviewed
Sep 22, 2021
xmudrii
approved these changes
Sep 23, 2021
|
LGTM label has been added. Git tree hash: ff8c286e3293df298e50a56f204a5a300efa98fc
|
xmudrii
pushed a commit
that referenced
this pull request
Oct 27, 2021
Signed-off-by: Artiom Diomin <kron82@gmail.com>
|
Cherry-picked to release/v1.3 branch with #1592. |
kubermatic-bot
pushed a commit
that referenced
this pull request
Oct 27, 2021
* edit selinux config file only if file exists (#1532) Signed-off-by: Artiom Diomin <kron82@gmail.com> * openstack-terraform: open nodeports SG (#1530) Signed-off-by: Artiom Diomin <kron82@gmail.com> * gce-terraform: Open GCE nodeports (#1529) Signed-off-by: Artiom Diomin <kron82@gmail.com> * azure-terraform: allow nodeports (#1528) Signed-off-by: Artiom Diomin <kron82@gmail.com> * Bump Hetzner Cloud CCM to latest version (#1583) Signed-off-by: Mattias Gees <mattias.gees@gmail.com> Co-authored-by: Artiom Diomin <artiom@loodse.com> Co-authored-by: Mattias Gees <mattias.gees@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Open nodeports by default for azure cluster
Special notes for your reviewer:
Found during v1.3.0 testing
Potentially fixes
Azure ingress is not accessible via Load Balancer#1307Does this PR introduce a user-facing change?: