Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flatcar terraform vSphere example #1838

Merged
merged 1 commit into from
Feb 11, 2022
Merged

Flatcar terraform vSphere example #1838

merged 1 commit into from
Feb 11, 2022

Conversation

kron4eg
Copy link
Member

@kron4eg kron4eg commented Feb 11, 2022

What this PR does / why we need it:
Flatcar vsphere example is quite different from other OSes because it needs ignition

Does this PR introduce a user-facing change?:

Flatcar terraform vSphere example

@kron4eg
flatcar vSphere example
4e9d2ce 
Signed-off-by: Artiom Diomin <kron82@gmail.com>
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 11, 2022
moadqassem
moadqassem approved these changes Feb 11, 2022
View reviewed changes
Copy link
Member

@moadqassem moadqassem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 11, 2022
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 910c359e06eb8eaa4381f2d65ce0f138d8e1c811

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg, moadqassem

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xmudrii xmudrii added this to the KubeOne 1.4 milestone Feb 11, 2022
@kubermatic-bot kubermatic-bot merged commit b48a2a8 into kubermatic:master Feb 11, 2022
@xmudrii xmudrii mentioned this pull request Feb 11, 2022
Merged
@kron4eg kron4eg deleted the vsphere_flatcar branch August 29, 2022 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

@moadqassem moadqassem moadqassem approved these changes

Assignees

@moadqassem moadqassem

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
KubeOne 1.4
Development

Successfully merging this pull request may close these issues.
4 participants
@kron4eg @kubermatic-bot @moadqassem @xmudrii