Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/v1.4] Approve pending CSRs when upgrading nodes #1888

Conversation

kubermatic-bot
Copy link
Contributor

This is an automated cherry-pick of #1887

/assign xmudrii

Approve pending CSRs when upgrading control plane and static worker nodes

Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@kubermatic-bot kubermatic-bot added this to the KubeOne 1.4 milestone Mar 9, 2022
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Mar 9, 2022
@kubermatic-bot kubermatic-bot added do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 9, 2022
@kron4eg
Copy link
Member

kron4eg commented Mar 9, 2022

/kind bug
/approve
/lgtm

@kubermatic-bot kubermatic-bot added the kind/bug Categorizes issue or PR as related to a bug. label Mar 9, 2022
@kubermatic-bot kubermatic-bot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Mar 9, 2022
@kubermatic-bot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg, kubermatic-bot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot
Copy link
Contributor Author

LGTM label has been added.

Git tree hash: 521a783c476a6c6584bb6f2b8fac99734aed20b2

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 9, 2022
@kubermatic-bot kubermatic-bot merged commit 4d299b8 into kubermatic:release/v1.4 Mar 9, 2022
@kubermatic-bot kubermatic-bot deleted the cherry-pick-1887-to-release/v1.4 branch October 4, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants