Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade CLI #201

Merged
merged 5 commits into from
Feb 15, 2019
Merged

upgrade CLI #201

merged 5 commits into from
Feb 15, 2019

Conversation

kron4eg
Copy link
Member

@kron4eg kron4eg commented Feb 14, 2019

What this PR does / why we need it:
Skeleton for kubeone upgrade to integrate with

Partially #196

NONE

@kubermatic-bot kubermatic-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 14, 2019
@kron4eg kron4eg requested a review from xmudrii February 14, 2019 15:39
@xmudrii
Copy link
Member

xmudrii commented Feb 14, 2019 •
edited
Loading

Did you run dep ensure? I don't see pflag being vendored in this PR and I think we never used it before. Forget about that, it's in the lock file.

@xmudrii
Copy link
Member

xmudrii commented Feb 14, 2019

/lgtm
/hold
until release :shipit:

@kubermatic-bot kubermatic-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Feb 14, 2019
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7adf7613bc3fe9f7255672b2478ad4231fd23c0c

@kubermatic-bot kubermatic-bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 14, 2019
@xmudrii
Copy link
Member

xmudrii commented Feb 14, 2019

/test pull-kubeone-dependencies

@kron4eg
Copy link
Member Author

kron4eg commented Feb 15, 2019

/hold cancel

@kubermatic-bot kubermatic-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 15, 2019
@xmudrii
Copy link
Member

xmudrii commented Feb 15, 2019

/lgtm
/approve
/hold cancel

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 15, 2019
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b565cfc058407b1f13147244b3af00954d0a4449

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 15, 2019
@xmudrii
Copy link
Member

xmudrii commented Feb 15, 2019

This seems like a flake. 🤔
/retest

@kubermatic-bot kubermatic-bot merged commit 01cf63d into master Feb 15, 2019
@kubermatic-bot kubermatic-bot deleted the 196-upgrade-cli branch February 15, 2019 14:25
@kdomanski kdomanski mentioned this pull request Feb 26, 2019
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii left review comments

Assignees

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kron4eg @xmudrii @kubermatic-bot