Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Openstack: Create router subnet link when router was created #4521

Merged
merged 1 commit into from
Oct 21, 2019
Merged

Openstack: Create router subnet link when router was created #4521

merged 1 commit into from
Oct 21, 2019

Conversation

alvaroaleman
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Documentation:

Does this PR introduce a user-facing change?:

Openstack: Fixed a bug that resulted in the router not being attached to the subnet when the subnet was manually created

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. approved Indicates a PR has been approved by an approver from all required OWNERS files. team/lifecycle size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 21, 2019
@kdomanski
Copy link
Contributor

/approve
/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 21, 2019
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f3933a2ffbcc9a8ce979fdea25460d3804d5fc91

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, kdomanski

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@alvaroaleman
Copy link
Contributor Author

/retest

@kubermatic-bot kubermatic-bot merged commit 576a4fa into master Oct 21, 2019
@kubermatic-bot kubermatic-bot added this to the v2.12 milestone Oct 21, 2019
@kubermatic-bot kubermatic-bot deleted the add-router branch October 21, 2019 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kdomanski kdomanski

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v2.12
Development

Successfully merging this pull request may close these issues.
3 participants
@alvaroaleman @kdomanski @kubermatic-bot