Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use official Nutanix SDK for Go #1457

Merged
merged 1 commit into from
Oct 24, 2022
Merged

Use official Nutanix SDK for Go #1457

merged 1 commit into from
Oct 24, 2022

Conversation

embik
Copy link
Member

@embik embik commented Oct 10, 2022 •
edited
Loading

What this PR does / why we need it:

This moves from a self-maintained version of the Nutanix SDK to the official source maintained by Nutanix.

Which issue(s) this PR fixes:

Fixes #1419

What type of PR is this?
/kind cleanup

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

NONE

Documentation:

NONE

@kubermatic-bot kubermatic-bot added docs/none Denotes a PR that doesn't need documentation (changes). kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. sig/osm Denotes a PR or issue as being assigned to SIG OSM. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 10, 2022
@embik
Copy link
Member Author

embik commented Oct 10, 2022

A dependency injected by the Nutanix SDK is down right now, thus builds are failing. See keploy/keploy#212 for upstream issue I've opened.

@embik
Copy link
Member Author

embik commented Oct 11, 2022

/retest

1 similar comment
@embik
Copy link
Member Author

embik commented Oct 17, 2022

/retest

@embik
Use official Nutanix SDK for Go
7255d4d 
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
@kubermatic-bot
Copy link
Contributor

kubermatic-bot commented Oct 18, 2022 •
edited
Loading

@embik: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-machine-controller-e2e-deployment-upgrade 70236fc link true /test pull-machine-controller-e2e-deployment-upgrade

Full PR test history

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@embik
Copy link
Member Author

embik commented Oct 18, 2022

/retest

ahmedwaleedmalik
ahmedwaleedmalik approved these changes Oct 24, 2022
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 24, 2022
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 31bd0ce80da01d57669698bbcce89bdbaafa6968

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, embik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 24, 2022
@kubermatic-bot kubermatic-bot merged commit debfca7 into kubermatic:main Oct 24, 2022
@embik embik deleted the nutanix-official-sdk branch October 24, 2022 08:18
lucakuendig pushed a commit to lucakuendig/machine-controller that referenced this pull request Oct 28, 2022
@embik @lucakuendig
Use official Nutanix SDK for Go (kubermatic#1457)
1248fff 
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>

Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
mate4st pushed a commit to mate4st/machine-controller that referenced this pull request Mar 13, 2023
@embik @mate4st
Use official Nutanix SDK for Go (kubermatic#1457)
052a8fe 
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>

Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedwaleedmalik ahmedwaleedmalik ahmedwaleedmalik approved these changes

Assignees

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. sig/osm Denotes a PR or issue as being assigned to SIG OSM. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move to github.com/nutanix-cloud-native/prism-go-client for Nutanix client
3 participants
@embik @kubermatic-bot @ahmedwaleedmalik