Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring of KubeVirt PVC image source #1529

Merged
merged 1 commit into from
Jan 19, 2023
Merged

Refactoring of KubeVirt PVC image source #1529

merged 1 commit into from
Jan 19, 2023

Conversation

mfranczy
Copy link
Contributor

@mfranczy mfranczy commented Jan 12, 2023 •
edited
Loading

What this PR does / why we need it:
Remove env vars that control PVC source.

Which issue(s) this PR fixes:

Fixes #

What type of PR is this?
/kind feature

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

Remove KubeVirt image PVC source control from env vars

Documentation:

NONE

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. docs/none Denotes a PR that doesn't need documentation (changes). dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/virtualization Denotes a PR or issue as being assigned to SIG Virtualization. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 12, 2023
@mfranczy
Copy link
Contributor Author

/hold

didn't test yet, however @hdurand0710 it's good for a review

@kubermatic-bot kubermatic-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 12, 2023
@hdurand0710
Copy link
Contributor

/retest

@hdurand0710
Copy link
Contributor

/approve
I like it, I let you test, but looks good!

@hdurand0710 hdurand0710 mentioned this pull request Jan 16, 2023
Closed
@mfranczy
Copy link
Contributor Author

/retest

@mfranczy
Copy link
Contributor Author

/test pull-machine-controller-e2e-kubevirt

1 similar comment
@mfranczy
Copy link
Contributor Author

/test pull-machine-controller-e2e-kubevirt

@mfranczy
Remove env vars that control PVC clone.
6bb2be5 
Signed-off-by: Marcin Franczyk <marcin0franczyk@gmail.com>
@mfranczy mfranczy changed the title Refactoring of KubeVirt image cloning Refactoring of KubeVirt PVC source for images. Jan 17, 2023
@mfranczy
Copy link
Contributor Author

/hold cancel

@kubermatic-bot kubermatic-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 17, 2023
@mfranczy
Copy link
Contributor Author

/retest

@hdurand0710 hdurand0710 self-assigned this Jan 18, 2023
@mfranczy
Copy link
Contributor Author

/retest

1 similar comment
@mfranczy
Copy link
Contributor Author

/retest

@mfranczy mfranczy changed the title Refactoring of KubeVirt PVC source for images. Refactoring of KubeVirt PVC image source Jan 19, 2023
@mfranczy mfranczy mentioned this pull request Jan 19, 2023
Closed
@hdurand0710
Copy link
Contributor

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 19, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: fa4abbe6494b85e5aaa815187e3fef6e808f158d

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hdurand0710, mfranczy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot merged commit 08e62dc into kubermatic:main Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@hdurand0710 hdurand0710

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/virtualization Denotes a PR or issue as being assigned to SIG Virtualization. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mfranczy @hdurand0710 @kubermatic-bot