Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basic support for vultr provider #1531

Merged
merged 1 commit into from
Feb 20, 2023
Merged

Basic support for vultr provider #1531

merged 1 commit into from
Feb 20, 2023

Conversation

2000yeshu
Copy link
Contributor

@2000yeshu 2000yeshu commented Jan 12, 2023 •
edited by ahmedwaleedmalik
Loading

Signed-off-by: Yakul Garg 2000yeshu@gmail.com

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #1530

What type of PR is this?

/kind feature

Special notes for your reviewer:
Does this PR introduce a user-facing change? Then add your Release Note here:

Support for Vultr cloud provider

Documentation:

TBD

@kubermatic-bot kubermatic-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. do-not-merge/docs-needed Indicates that a PR should not merge because it's missing one of the documentation labels. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. sig/osm Denotes a PR or issue as being assigned to SIG OSM. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 12, 2023
@kubermatic-bot
Copy link
Contributor

Hi @2000yeshu. Thanks for your PR.

I'm waiting for a kubermatic member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot kubermatic-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jan 12, 2023
@2000yeshu 2000yeshu marked this pull request as ready for review January 15, 2023 12:58
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 15, 2023
@2000yeshu 2000yeshu changed the title Add vultr provider interface methods Add vultr provider interface methods(Basic) Jan 15, 2023
@2000yeshu 2000yeshu changed the title Add vultr provider interface methods(Basic) Basic support for vultr provider Jan 15, 2023
@kubermatic-bot kubermatic-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 15, 2023
@2000yeshu
Copy link
Contributor Author

This adds basic support for vultr provider. All vultr API options are not yet supported

@lakshmanpasala
Copy link

What's the status of this? Can some one review this soon? This will save a ton of time for me.

@igniteram
Copy link

@ahmedwaleedmalik @embik Can you please look into this PR, this would be great for all Vultr cloud users!

@ahmedwaleedmalik
Copy link
Member

@2000yeshu thanks for the awesome contribution.

We have a similar PR open for Vultr already as well #1421. Although it was stalled because we don't have a way to test this cloud provider.

We will discuss this PR internally on Monday hopefully and then proceed with this. Can you please compare your changes with #1421 to make sure that you are not missing out on any essential configuration etc.

cc @jonatasbaldin @dajudge as consumers of machine-controller you folks might also be interested in this.

@ahmedwaleedmalik
Copy link
Member

/ok-to-test

@kubermatic-bot kubermatic-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 4, 2023
@ahmedwaleedmalik ahmedwaleedmalik added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 4, 2023
@kubermatic-bot kubermatic-bot added docs/tbd Denotes a PR that needs documentation (change) that will be done later. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/docs-needed Indicates that a PR should not merge because it's missing one of the documentation labels. release-note-none Denotes a PR that doesn't merit a release note. labels Feb 4, 2023
@2000yeshu
Copy link
Contributor Author

@ahmedwaleedmalik cross-checked my PR with #1421. I have added one more optional parameter named osId compared to that and made changes to the example vultr manifest to show all params.

@ahmedwaleedmalik
Copy link
Member

Can you please fix the following failing jobs:

  • pull-machine-controller-license-validation
  • pull-machine-controller-lint
  • pull-machine-controller-test
  • pull-machine-controller-verify-boilerplate

Disable pull-machine-controller-e2e-vultr since we don't have any active account unfortunately to test for that cloud provider.

@ahmedwaleedmalik
Copy link
Member

@2000yeshu did you get a chance to take a look on this?

@2000yeshu
Copy link
Contributor Author

Hey @ahmedwaleedmalik, i will fix this tomorrow. Sorry, didnt get a chance to look at this.

@2000yeshu 2000yeshu force-pushed the add-vultr-provider branch 4 times, most recently from 0f828b9 to 7fce7b8 Compare February 16, 2023 21:55
@2000yeshu
Copy link
Contributor Author

@ahmedwaleedmalik, have fixed the tests.

ahmedwaleedmalik
ahmedwaleedmalik requested changes Feb 17, 2023
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits

pkg/cloudprovider/provider/vultr/provider.go Outdated Show resolved Hide resolved
pkg/cloudprovider/provider/vultr/provider.go Outdated Show resolved Hide resolved
pkg/cloudprovider/provider/vultr/provider.go Outdated Show resolved Hide resolved
pkg/cloudprovider/provider/vultr/types/types.go Outdated Show resolved Hide resolved
@2000yeshu
Add basic support for vultr cloud provider
7adc5b6 
Signed-off-by: Yakul Garg <2000yeshu@gmail.com>
@2000yeshu
Copy link
Contributor Author

Done

ahmedwaleedmalik
ahmedwaleedmalik approved these changes Feb 20, 2023
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@2000yeshu thank you for this awesome contribution. 🎊

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 20, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ca4b80394bf1b84ee4278417b4d97aa91a342151

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 2000yeshu, ahmedwaleedmalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 20, 2023
@kubermatic-bot
Copy link
Contributor

kubermatic-bot commented Feb 20, 2023 •
edited
Loading

@2000yeshu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-machine-controller-e2e-vultr b5c8ce8 link true /test pull-machine-controller-e2e-vultr
pull-machine-controller-e2e-azure b5c8ce8 link true /test pull-machine-controller-e2e-azure

Full PR test history

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kubermatic-bot kubermatic-bot merged commit 1176b4c into kubermatic:main Feb 20, 2023
@ahmedwaleedmalik ahmedwaleedmalik mentioned this pull request Feb 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedwaleedmalik ahmedwaleedmalik ahmedwaleedmalik approved these changes

Assignees

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/tbd Denotes a PR that needs documentation (change) that will be done later. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. sig/osm Denotes a PR or issue as being assigned to SIG OSM. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for vultr
5 participants
@2000yeshu @kubermatic-bot @lakshmanpasala @igniteram @ahmedwaleedmalik