Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/v1.54] Anexia Provider: configure rpc-statd service as kubelet dependency #1578

Merged
merged 2 commits into from
Feb 27, 2023
Merged

[release/v1.54] Anexia Provider: configure rpc-statd service as kubelet dependency #1578

merged 2 commits into from
Feb 27, 2023

Conversation

marioreggiori
Copy link
Contributor

What this PR does / why we need it:
This is a manual cherry-pick of #1553

Does this PR introduce a user-facing change? Then add your Release Note here:

Enables "rpc-statd" service on new Anexia Machines using Flatcar with cloud-init to enable NFS functionality required by Anexia CSI driver.

Mario Schäfer added 2 commits February 27, 2023 10:04
Anexia Provider: configure rpc-statd service as kubelet dependency
79ca47a 
Signed-off-by: Mario Schäfer <mschaefer@anexia-it.com>
Update flatcar cloudinit fixtures
3e57db2 
Signed-off-by: Mario Schäfer <mschaefer@anexia-it.com>
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/osm Denotes a PR or issue as being assigned to SIG OSM. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 27, 2023
@kubermatic-bot
Copy link
Contributor

Hi @marioreggiori. Thanks for your PR.

I'm waiting for a kubermatic member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot kubermatic-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 27, 2023
ahmedwaleedmalik
ahmedwaleedmalik approved these changes Feb 27, 2023
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 27, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ae92a6212e80455c569c0b6606c33f0d9a9df88d

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, marioreggiori

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2023
@xrstf
Copy link
Contributor

xrstf commented Feb 27, 2023

Please adjust the release branch, these are not flakes.

/override pull-machine-controller-e2e-kubevirt
/override pull-machine-controller-e2e-vmware-cloud-director
/override pull-machine-controller-e2e-vsphere

@kubermatic-bot
Copy link
Contributor

@xrstf: Overrode contexts on behalf of xrstf: pull-machine-controller-e2e-kubevirt, pull-machine-controller-e2e-vmware-cloud-director, pull-machine-controller-e2e-vsphere

In response to this:

Please adjust the release branch, these are not flakes.

/override pull-machine-controller-e2e-kubevirt
/override pull-machine-controller-e2e-vmware-cloud-director
/override pull-machine-controller-e2e-vsphere

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot kubermatic-bot merged commit f387c0e into kubermatic:release/v1.54 Feb 27, 2023
@marioreggiori
Copy link
Contributor Author

Please adjust the release branch, these are not flakes.

@xrstf I assume those errors are unrelated to this PR and this message wasn't directed to me?

@ahmedwaleedmalik
Copy link
Member

Please adjust the release branch, these are not flakes.

@xrstf I assume those errors are unrelated to this PR and this message wasn't directed to me?

This message was for me and our dev team :D Not directed to you folks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedwaleedmalik ahmedwaleedmalik ahmedwaleedmalik approved these changes

Assignees

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/osm Denotes a PR or issue as being assigned to SIG OSM. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marioreggiori @kubermatic-bot @xrstf @ahmedwaleedmalik