Support Private IP for Hetzner Cloud #1579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Moath Qasim <moad.qassem@gmail.com>
Signed-off-by: Moath Qasim <moad.qassem@gmail.com>
kubermatic-bot
added
kind/feature
Signed-off-by: Moath Qasim <moad.qassem@gmail.com>
|
This should also somewhat solve kubermatic/operating-system-manager#230 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmedwaleedmalik, moadqassem The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. Git tree hash: 9c29e61eb5764703c363beba2ffca565e8ff33a7
|
eiabea
pushed a commit
to anexia-it/machine-controller
that referenced
this pull request
May 8, 2023
* support private ip for hetzner cloud Signed-off-by: Moath Qasim <moad.qassem@gmail.com> * document hetzner ips assignment Signed-off-by: Moath Qasim <moad.qassem@gmail.com> * fix linting Signed-off-by: Moath Qasim <moad.qassem@gmail.com> --------- Signed-off-by: Moath Qasim <moad.qassem@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds support for disabling the allocation and assignment of public IPv4 and IPv6 by default. Two new fields are introduced(
assignPublicIPv4andassignPublicIPv6) when set, the values are gonna be set and propagated to the hetzner vms. If those are not set, the default behaviour is assigning public IPs.Which issue(s) this PR fixes:
Fixes #
What type of PR is this?
/kind feature
Special notes for your reviewer:
Does this PR introduce a user-facing change? Then add your Release Note here:
Documentation: