Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove DisableStrictZoneCheck from AWS 1.27 cloud-config #1638

Merged
merged 1 commit into from
May 11, 2023
Merged

Remove DisableStrictZoneCheck from AWS 1.27 cloud-config #1638

merged 1 commit into from
May 11, 2023

Conversation

xrstf
Copy link
Contributor

@xrstf xrstf commented May 11, 2023

What this PR does / why we need it:
kubernetes/cloud-provider-aws#573 removed the DisableStrictZoneCheck field alltogether from the cloud-config. The new CCM will reject and fail to load an old cloud-config, so we must ensure that the field is not part of the cloud-config at all.

This PR achieves this by only rendering the field if it's enabled, shifting the burden to set it properly onto our consumers.

What type of PR is this?
/kind bug

Does this PR introduce a user-facing change? Then add your Release Note here:

For generating cloud-config for Kubernetes 1.27 machines on AWS, make sure to set `DisableStrictZoneCheck` to `false`, as the flag is not supported in 1.27+ anymore.

Documentation:

NONE

@kubermatic-bot kubermatic-bot added docs/none Denotes a PR that doesn't need documentation (changes). release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 11, 2023
ahmedwaleedmalik
ahmedwaleedmalik approved these changes May 11, 2023
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

We'll need the same changes in OSM as well @xrstf

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label May 11, 2023
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ahmedwaleedmalik,xrstf]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 363a0d86eddca495ab2769682239dba3316affc8

@ahmedwaleedmalik ahmedwaleedmalik changed the title remove DisableStrictZoneCheck from AWS 1.27 cloud-config Remove DisableStrictZoneCheck from AWS 1.27 cloud-config May 11, 2023
@kubermatic-bot kubermatic-bot removed the lgtm Indicates that a PR is ready to be merged. label May 11, 2023
@ahmedwaleedmalik
Copy link
Member

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label May 11, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a3512e31e15997e8cc2d0e019cc6fa790f17b7ab

@xrstf
Copy link
Contributor Author

xrstf commented May 11, 2023

/retest

@xrstf
Copy link
Contributor Author

xrstf commented May 11, 2023

/override pull-machine-controller-e2e-aws-spot-instance
/override pull-machine-controller-e2e-aws-spot-instance-legacy-userdata

AWS is out of capacity for spot instances.

@kubermatic-bot
Copy link
Contributor

@xrstf: Overrode contexts on behalf of xrstf: pull-machine-controller-e2e-aws-spot-instance, pull-machine-controller-e2e-aws-spot-instance-legacy-userdata

In response to this:

/override pull-machine-controller-e2e-aws-spot-instance
/override pull-machine-controller-e2e-aws-spot-instance-legacy-userdata

AWS is out of capacity for spot instances.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot kubermatic-bot merged commit bc2e86d into kubermatic:main May 11, 2023
@xrstf xrstf deleted the aws-improvement branch May 11, 2023 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedwaleedmalik ahmedwaleedmalik Awaiting requested review from ahmedwaleedmalik

Assignees

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xrstf @kubermatic-bot @ahmedwaleedmalik