[release/v1.56] Allow external CCMs to handle node objects before MC #1652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marcin Franczyk <marcin0franczyk@gmail.com>
Signed-off-by: Marcin Franczyk <marcin0franczyk@gmail.com>
kubermatic-bot
added
release-note
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mfranczy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubermatic-bot
added
sig/cluster-management
|
/test pull-machine-controller-e2e-kubevirt |
|
/retest |
Otherwise we have a race condition between MC and CCM. Both try to check status of instances at cloud provider. If MC reconciles instances first then kubelet will reuse the old node object which is problematic in case of IP change. Signed-off-by: Marcin Franczyk <marcin0franczyk@gmail.com>
Signed-off-by: Marcin Franczyk <marcin0franczyk@gmail.com>
Signed-off-by: Marcin Franczyk <marcin0franczyk@gmail.com>
mfranczy
force-pushed
the
ccm-instance-handler-1.56
branch
from
9723307
to
8defb7f
Compare
|
/test pull-machine-controller-e2e-gce |
embik
approved these changes
Jun 5, 2023
|
LGTM label has been added. Git tree hash: b1fcc5a94ebdd8353b55d9d2a4d8fd7bab71b0c6
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual backport of #1645
What this PR does / why we need it:
Allow external CCMs to handle failing node objects before MC takes any action.
It prevents race condition between MC and CCM.
The PR introduces a
handleNodeFailuresWithExternalCCMfunction that:Which issue(s) this PR fixes:
Fixes kubermatic/kubermatic#12218
What type of PR is this?
/kind bug
Special notes for your reviewer:
Does this PR introduce a user-facing change? Then add your Release Note here:
Documentation: