Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VCD: Fix compute and sizing policies #1685

Merged
merged 1 commit into from
Jul 21, 2023
Merged

VCD: Fix compute and sizing policies #1685

merged 1 commit into from
Jul 21, 2023

Conversation

ahmedwaleedmalik
Copy link
Member

What this PR does / why we need it:
This PR fixes propagation of compute and sizing policies for VMware Cloud Director.

Which issue(s) this PR fixes:

Fixes #

What type of PR is this?

/kind bug

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

Fix assignment of compute and sizing policies for VMware Cloud Director

Documentation:

NONE

@ahmedwaleedmalik ahmedwaleedmalik self-assigned this Jul 21, 2023
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. docs/none Denotes a PR that doesn't need documentation (changes). dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 21, 2023
@ahmedwaleedmalik
Copy link
Member Author

/cherry-pick release/v1.54

@kubermatic-bot
Copy link
Contributor

@ahmedwaleedmalik: once the present PR merges, I will cherry-pick it on top of release/v1.54 in a new PR and assign it to you.

In response to this:

/cherry-pick release/v1.54

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ahmedwaleedmalik
Copy link
Member Author

/cherry-pick release/v1.56

@kubermatic-bot
Copy link
Contributor

@ahmedwaleedmalik: once the present PR merges, I will cherry-pick it on top of release/v1.56 in a new PR and assign it to you.

In response to this:

/cherry-pick release/v1.56

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ahmedwaleedmalik
Copy link
Member Author

/cherry-pick release/v1.57

@kubermatic-bot
Copy link
Contributor

@ahmedwaleedmalik: once the present PR merges, I will cherry-pick it on top of release/v1.57 in a new PR and assign it to you.

In response to this:

/cherry-pick release/v1.57

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ahmedwaleedmalik ahmedwaleedmalik force-pushed the vcd-policies branch 2 times, most recently from 7544390 to 7cf9a31 Compare July 21, 2023 11:22
@kubermatic-bot kubermatic-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 21, 2023
@ahmedwaleedmalik
VCD: Fix compute and sizing policies
05e4807 
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
@ahmedwaleedmalik ahmedwaleedmalik added the backport-needed Denotes a PR or issue that has not been fully backported. label Jul 21, 2023
xrstf
xrstf approved these changes Jul 21, 2023
View reviewed changes
Copy link
Contributor

@xrstf xrstf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 21, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 44f4aec3601a4cf14be7af10b9dc621f2f23a31b

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ahmedwaleedmalik,xrstf]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot merged commit d285b8f into kubermatic:main Jul 21, 2023
@ahmedwaleedmalik ahmedwaleedmalik deleted the vcd-policies branch July 21, 2023 14:32
@kubermatic-bot
Copy link
Contributor

@ahmedwaleedmalik: new pull request created: #1686

In response to this:

/cherry-pick release/v1.54

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Jul 21, 2023
Merged
Merged
@kubermatic-bot
Copy link
Contributor

@ahmedwaleedmalik: new pull request created: #1687

In response to this:

/cherry-pick release/v1.56

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot
Copy link
Contributor

@ahmedwaleedmalik: new pull request created: #1688

In response to this:

/cherry-pick release/v1.57

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot kubermatic-bot mentioned this pull request Jul 21, 2023
Merged
@embik embik mentioned this pull request Jul 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xrstf xrstf xrstf approved these changes

@moadqassem moadqassem Awaiting requested review from moadqassem

Assignees

@xrstf xrstf

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-needed Denotes a PR or issue that has not been fully backported. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahmedwaleedmalik @kubermatic-bot @xrstf