Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

master/seed mla stack requires port numberts for scraping #57

Closed
wants to merge 1 commit into from
Closed

master/seed mla stack requires port numberts for scraping #57

wants to merge 1 commit into from

Conversation

wurbanski
Copy link
Contributor

This changes the annotations to use port number, so that prometheus can scrape the targets.

This means that port number has to be managed in multiple places, unfortunately, but this is a temporary solution.

@kubermatic-bot kubermatic-bot added dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 2, 2021
@rastislavs
Copy link
Contributor

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 2, 2021
@kubermatic-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rastislavs, wurbanski

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot
Copy link

LGTM label has been added.

Git tree hash: 7af453ebcc001e6b3069df5eba71c77fa2846447

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 2, 2021
@aborilov
Copy link
Contributor

aborilov commented Sep 2, 2021

/lgtm

@jiachengxu
Copy link
Contributor

/hold

@kubermatic-bot kubermatic-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 2, 2021
@wurbanski wurbanski closed this Sep 2, 2021
@wurbanski
Copy link
Contributor Author

This is already overriden in config/cortex/values.yaml

@rastislavs rastislavs deleted the port-numbers-for-scraping branch September 16, 2021 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aborilov aborilov Awaiting requested review from aborilov

@rastislavs rastislavs Awaiting requested review from rastislavs

Assignees

@aborilov aborilov

@rastislavs rastislavs

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wurbanski @rastislavs @kubermatic-bot @aborilov @jiachengxu