Windows adaptations and installation configuration

[ahmedyarub]

Should be merged after OpenAPITools/openapi-generator#10326
Includes fixes for Windows and installation configuration.

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
• Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: login-issues@jira.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[ahmedyarub]

I signed it

[ahmedalnuaimi]

I signed it

[ityuhui]

cmake .. will fail in my env:

CMake Error at CMakeLists.txt:1566 (install):
  install TARGETS given no LIBRARY DESTINATION for shared library target
  "kubernetes".


CMake Error at CMakeLists.txt:1584 (export):
  export Export set "kubernetesTargets" not found.

After I changed the line 1655
to

install(TARGETS ${pkgName} DESTINATION ${CMAKE_INSTALL_PREFIX}

It works.

[ahmedyarub]

I can build and install on both Ubuntu 20.04 and Windows without any problem.

[ityuhui]

I know. But on my env (Ubuntu 18.04 and default cmake), this change is needed. I think "DESTINATION" is required but new version of cmake can ignore it.

[ahmedyarub]

Requested changes made and a new PR opened OpenAPITools/openapi-generator#10378

[ityuhui]

The build of libkubernetes.so will fail:

/usr/bin/ld: /usr/local/lib/libyaml.a(api.c.o): relocation R_X86_64_PC32 against symbol `yaml_realloc' can not be used when making a shared object; recompile with -fPIC
/usr/bin/ld: final link failed: Bad value
collect2: error: ld returned 1 exit status
CMakeFiles/kubernetes.dir/build.make:19861: recipe for target 'libkubernetes.so' failed
make[2]: *** [libkubernetes.so] Error 1
CMakeFiles/Makefile2:67: recipe for target 'CMakeFiles/kubernetes.dir/all' failed
make[1]: *** [CMakeFiles/kubernetes.dir/all] Error 2
Makefile:129: recipe for target 'all' failed
make: *** [all] Error 2

After I rebuilt and installed libyaml to a shared library:

user@machine:~/libyaml/build# cmake .. -DBUILD_SHARED_LIBS=1
sudo make install

The libkubernetes.so can be built successfully.

[ahmedyarub]

The build of libkubernetes.so will fail:

/usr/bin/ld: /usr/local/lib/libyaml.a(api.c.o): relocation R_X86_64_PC32 against symbol `yaml_realloc' can not be used when making a shared object; recompile with -fPIC
/usr/bin/ld: final link failed: Bad value
collect2: error: ld returned 1 exit status
CMakeFiles/kubernetes.dir/build.make:19861: recipe for target 'libkubernetes.so' failed
make[2]: *** [libkubernetes.so] Error 1
CMakeFiles/Makefile2:67: recipe for target 'CMakeFiles/kubernetes.dir/all' failed
make[1]: *** [CMakeFiles/kubernetes.dir/all] Error 2
Makefile:129: recipe for target 'all' failed
make: *** [all] Error 2

After I rebuilt and installed libyaml to a shared library:

user@machine:~/libyaml/build# cmake .. -DBUILD_SHARED_LIBS=1
sudo make install

The libkubernetes.so can be built successfully.

Do you propose making a change here?

[ityuhui]

Yes. I suggest updating the readme and actions/workflow to build libyaml as a shared library.

cmake -DCMAKE_INSTALL_PREFIX=/usr/local -DBUILD_TESTING=OFF -DBUILD_SHARED_LIBS=1 .. 

[ahmedyarub]

 -DBUILD_SHARED_LIBS=

Done

[ahmedyarub]

Next I'll make some adaptations for Android, iOS, MacOS and possibly WASM!

[ityuhui]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedyarub, ityuhui

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ityuhui]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ityuhui]

@ahmedyarub Thanks to your contribution now the C client library supports Windows !

[ahmedyarub]

@ahmedyarub Thanks to your contribution now the C client library supports Windows !

Next I'll work on adaptations for Android, MacOS, iOS, and Emscripten

[ityuhui]

Hi @ahmedyarub

• Supporting MacOS is useful !
• But I am afraid that users rarely use the C client library on Android or iOS...
• For the Emscripten, as far as I known, it is used to convert C code to asm.js, but what's the purpose because community has a Javascript client library (https://github.com/kubernetes-client/javascript)