Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

force using AES for cert algo #1345

Merged
merged 5 commits into from
Sep 11, 2023
Merged

Conversation

tg123
Copy link
Member

@tg123 tg123 commented Jul 23, 2023

follow up for #1343

after reviewing with .net security team, RC2 is no longer recommend

.SetKeyAlgorithm(NistObjectIdentifiers.IdAes128Cbc, PkcsObjectIdentifiers.IdHmacWithSha1)

this PR also move Classic certutils to its own project for readability

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 23, 2023
@tg123
Copy link
Member Author

tg123 commented Jul 23, 2023

cc @GrabYourPitchforks

@codecov-commenter
Copy link

codecov-commenter commented Jul 23, 2023

Codecov Report

❗ No coverage uploaded for pull request base (master@a3321e0). Click here to learn what that means.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff            @@
##             master    #1345   +/-   ##
=========================================
  Coverage          ?   70.35%           
=========================================
  Files             ?       90           
  Lines             ?     2709           
  Branches          ?        0           
=========================================
  Hits              ?     1906           
  Misses            ?      803           
  Partials          ?        0           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

📢 Have feedback on the report? Share it here.

@tg123
Copy link
Member Author

tg123 commented Jul 27, 2023

/hold

3DES is deprecated either.
seeking for AES solution

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 27, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 7, 2023
@tg123 tg123 changed the title force using 3des for cert algo force using AES for cert algo Sep 7, 2023
@tg123
Copy link
Member Author

tg123 commented Sep 7, 2023

/unhold

tested for AES in windows

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 7, 2023
@tg123
Copy link
Member Author

tg123 commented Sep 7, 2023

link the how to use aes with bc
bcgit/bc-csharp#234

@brendandburns
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 11, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, tg123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [brendandburns,tg123]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit c772d8e into kubernetes-client:master Sep 11, 2023
12 checks passed
@tg123 tg123 deleted the force3des branch September 26, 2023 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants