Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

embed KubernetesClient.Models and KubernetesClient.Basic into client sdk #1407

Merged
merged 7 commits into from
Sep 26, 2023

Conversation

tg123
Copy link
Member

@tg123 tg123 commented Sep 23, 2023

The old proposal that introduced KubernetesClient.Models and KubernetesClient.Basic #793

Why

In order to facilitate support net48. KubernetesClient.Models and KubernetesClient.Basic consistently maintained targeting netstandard2.0. However, the commitment to supporting netstandard2.0 has significantly constrained the KubernetesClient in terms of adopting newer .NET features, such as record models.

One of the core objectives behind introducing the KubernetesClient.Models and KubernetesClient.Basic was to foster third-party engagement, encouraging developers to create custom clients. However, this approach may appear somewhat over-designed, seems no actual adoption of this functionality. Furthermore, even after embedding, third-party clients retain the ability to implement customized client solutions by overriding the AbstractKubernetes.

With the embedding completed, both KubernetesClient and KubernetesClient.Classic can now follow their respective paths for independent development and enhancement.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 23, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 23, 2023
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 23, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2023

Codecov Report

❗ No coverage uploaded for pull request base (master@80c1315). Click here to learn what that means.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff            @@
##             master    #1407   +/-   ##
=========================================
  Coverage          ?   70.32%           
=========================================
  Files             ?       90           
  Lines             ?     2713           
  Branches          ?        0           
=========================================
  Hits              ?     1908           
  Misses            ?      805           
  Partials          ?        0           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@brendandburns
Copy link
Contributor

Is this a breaking change for users of the library?

Other than that question, looks good to me.

@tg123
Copy link
Member Author

tg123 commented Sep 25, 2023

Is this a breaking change for users of the library?

Other than that question, looks good to me.

no breaking change to users depend on KubenetesClient or KubernetesClient.Classic

no new version of Basic and Model anymore

@brendandburns
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 26, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, tg123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [brendandburns,tg123]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 013fc6e into kubernetes-client:master Sep 26, 2023
12 checks passed
@tg123 tg123 deleted the separatenuget branch October 13, 2023 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants