-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
embed KubernetesClient.Models and KubernetesClient.Basic into client sdk #1407
Conversation
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## master #1407 +/- ##
=========================================
Coverage ? 70.32%
=========================================
Files ? 90
Lines ? 2713
Branches ? 0
=========================================
Hits ? 1908
Misses ? 805
Partials ? 0 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Is this a breaking change for users of the library? Other than that question, looks good to me. |
no breaking change to users depend on KubenetesClient or KubernetesClient.Classic no new version of Basic and Model anymore |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, tg123 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The old proposal that introduced
KubernetesClient.Models
andKubernetesClient.Basic
#793Why
In order to facilitate support
net48
.KubernetesClient.Models
andKubernetesClient.Basic
consistently maintained targetingnetstandard2.0
. However, the commitment to supporting netstandard2.0 has significantly constrained theKubernetesClient
in terms of adopting newer .NET features, such as record models.One of the core objectives behind introducing the
KubernetesClient.Models
andKubernetesClient.Basic
was to foster third-party engagement, encouraging developers to create custom clients. However, this approach may appear somewhat over-designed, seems no actual adoption of this functionality. Furthermore, even after embedding, third-party clients retain the ability to implement customized client solutions by overriding theAbstractKubernetes
.With the embedding completed, both
KubernetesClient
andKubernetesClient.Classic
can now follow their respective paths for independent development and enhancement.