-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement exec over the SPDY protocol #410
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: admilazz The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @krabhishek8260 |
I'll review this after the dependent PRs are merged. |
I guess I'll put this in a separate project. |
@admilazz: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
P.S. I wouldn't say it's untested, though. :-) I did run 20,000 execs of various kinds in a row with zero failures... But it's true I haven't written unit tests yet. |
This change adds improved exec support. The existing exec support uses web sockets, which has a flawed protocol leading to some commands running forever. This change helps address issue #397 .
I tried to replace the implementation of the existing exec support to provide a seamless upgrade. Unfortunately, many internal implementation details of the web socket approach (e.g. WebSocketNamespacedPodExecAsync, MuxedStream, StreamDemuxer, etc), were publicly exposed, and it would be a breaking change to remove them. I did replace the implementation of NamespacedPodExecAsync, however, which was generic enough.
This PR makes the following public API changes:
NOTE: This PR builds on and includes changes from two other PRs (#405 and #406). I'm not sure how best to represent that in a PR, but the files actually added or changed in this specific PR are: