Optimize docker compilation time #193
Conversation
k8s-ci-robot
added
cncf-cla: yes
| @@ -56,6 +40,21 @@ RUN chown root:root /etc/apt/sources.list.d/microsoft-prod.list | |||
| RUN apt-get update | |||
| RUN apt-get install -yy -q dotnet-hosting-2.0.8 | |||
|
|
|||
| ARG OPENAPI_GENERATOR_COMMIT | |||
There was a problem hiding this comment.
Does moving the ARGs affect the caching? I feel like it is clearer if they are at the top.
There was a problem hiding this comment.
According to the documentation, when the ARG layer is changed, all the following layers of the cache will invalidate.
Reference:
https://docs.docker.com/engine/reference/builder/#impact-on-build-caching
https://stackoverflow.com/questions/41593135/does-putting-arg-at-top-of-dockerfile-prevent-layer-re-use
There was a problem hiding this comment.
There was a problem hiding this comment.
ok, thanks for the explanation.
|
One small, otherwise looks good. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, HongjiangHuang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Better use of docker layer cache