Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to Kubernetes 1.16 #60

Merged
merged 1 commit into from
Oct 9, 2019

Conversation

jonschoning
Copy link
Contributor

@jonschoning jonschoning commented Oct 7, 2019

  • update to Kubernetes 1.16
  • uses latest openapi-generator commit (kubernetes-client/gen@8b15007)
    • updates stack resolver lts-13.9 -> lts-14.7
    • uses custom format strings for _readDateTime, _showDateTime

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 7, 2019
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 7, 2019
@jonschoning
Copy link
Contributor Author

/approve cancel

@k8s-ci-robot k8s-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 7, 2019
@jonschoning
Copy link
Contributor Author

jonschoning commented Oct 7, 2019

ref: #53
supersedes: #55

@@ -0,0 +1,33 @@
# This file was autogenerated by Stack.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this file supposed to be checked in?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to https://docs.haskellstack.org/en/stable/lock_files/#lock-files it can be checked into source control, but it's not strictly necessary if we don't want to include it. I'm fine with either way.

@guoshimin
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 9, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guoshimin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 9, 2019
@k8s-ci-robot k8s-ci-robot merged commit 95eb28b into kubernetes-client:master Oct 9, 2019
@guoshimin
Copy link
Contributor

https://travis-ci.org/guoshimin/kubernetes-client-haskell/jobs/594710176

Do we no longer support GHC 8.0.2? Do you know what led to this and if that's OK?

@jonschoning
Copy link
Contributor Author

jonschoning commented Oct 9, 2019

the line it points to is this

newtype DateTime = DateTime { unDateTime :: TI.UTCTime }
  deriving (P.Eq,P.Data,P.Ord,P.Typeable,NF.NFData,TI.ParseTime,TI.FormatTime)
newtype Date = Date { unDate :: TI.Day }
  deriving (P.Enum,P.Eq,P.Data,P.Ord,P.Ix,NF.NFData,TI.ParseTime,TI.FormatTime)

odd, so it's in the deriving ParseTime and FormatTime

i noticed that build isn't using stack.. so lts-14.7 uses time-1.8.0.2, but your build using cabal is using time-1.9.3 which i haven't tested with.

perhaps we need to tighten the bounds on time if it doesn't build with time-1.9.3 , but i'd need to investigate further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants