-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update to Kubernetes 1.16 #60
update to Kubernetes 1.16 #60
Conversation
/approve cancel |
@@ -0,0 +1,33 @@ | |||
# This file was autogenerated by Stack. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this file supposed to be checked in?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to https://docs.haskellstack.org/en/stable/lock_files/#lock-files it can be checked into source control, but it's not strictly necessary if we don't want to include it. I'm fine with either way.
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guoshimin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
https://travis-ci.org/guoshimin/kubernetes-client-haskell/jobs/594710176 Do we no longer support GHC 8.0.2? Do you know what led to this and if that's OK? |
the line it points to is this
odd, so it's in the deriving ParseTime and FormatTime i noticed that build isn't using perhaps we need to tighten the bounds on |
lts-13.9 -> lts-14.7
_readDateTime
,_showDateTime