Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Legacy/Java8] Automated Generate from openapi release-1.28 #3028

Merged
merged 2 commits into from
Feb 6, 2024

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented Feb 2, 2024

No description provided.

Copy link

linux-foundation-easycla bot commented Feb 2, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Feb 2, 2024
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 2, 2024
@yue9944882 yue9944882 changed the title Automated Generate from openapi release-1.28 [Legacy/Java8] Automated Generate from openapi release-1.28 Feb 4, 2024
Signed-off-by: Min Jin <minkimzz@amazon.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Feb 5, 2024
Signed-off-by: Min Jin <minkimzz@amazon.com>
@yue9944882
Copy link
Member

added one more commit to align with the recent gen repo change: kubernetes-client/gen#260

@brendandburns
Copy link
Contributor

This looks good, but it seems like mostly this just changes the generated date? Are there more substantive changes to some files?

@yue9944882
Copy link
Member

This looks good, but it seems like mostly this just changes the generated date? Are there more substantive changes to some files?

it's true the first two commits. however the last commit is non-trivial one. i'm running re-generation to make sure that the code-generation workflow is working as expected in the repo. do you think we should discard these two PRs and proceed with maven publishing?

@brendandburns
Copy link
Contributor

/lgtm
/approve

I think it's fine to merge, I just wanted to confirm that it was expected.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 6, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, github-actions[bot]

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 6, 2024
@k8s-ci-robot k8s-ci-robot merged commit c08643c into master-java8 Feb 6, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants