-
Notifications
You must be signed in to change notification settings - Fork 185
corrected regex to properly parse microseconds #150
corrected regex to properly parse microseconds #150
Conversation
Welcome @goddenrich! |
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
please sign cla |
I did before submitting pr. A little confused why its not showing up. I have signed up with the same email address as used for git commits and my full name. should the name be the username for github (ie. goddenrich)? |
Codecov Report
@@ Coverage Diff @@
## master #150 +/- ##
==========================================
+ Coverage 93.44% 93.56% +0.11%
==========================================
Files 13 13
Lines 1374 1384 +10
==========================================
+ Hits 1284 1295 +11
+ Misses 90 89 -1
Continue to review full report at Codecov.
|
I signed it |
/check-cla |
@yliaog I have tried everything I can with the CLA. Just raised a ticket at jira.linuxfoundation.org to try to get this resolved |
/check-cla |
Okay now you're good for the CLA. |
thanks. please squash the commits. /lgtm |
I squashed commits and removed some unnecessary spaces. Thanks |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: goddenrich, yliaog The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
fixes issue #149