-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Look for a VolumeGroupSnapshotClass when getting the class of a VolumeGroupSnapshot #1115
Conversation
/lgtm |
…eGroupSnapshot Signed-off-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com>
I rebased it over the latest master |
/assign @xing-yang for approval |
@Madhu-1: GitHub didn't allow me to assign the following users: for, approval. Note that only kubernetes-csi members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leonardoce, Madhu-1, xing-yang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
What this PR does / why we need it:
When looking for the name of the CSI driver to use for a volume group snapshot, we were looking for a VolumeSnapshotClass instead of a VolumeGroupSnapshotClass. This made the VolumeGroupSnapshot fail when there is no such VolumeGroupSnapshotClass.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: