-
Notifications
You must be signed in to change notification settings - Fork 295
IAM Role name length checks need to account for StrictName usage... #1497
IAM Role name length checks need to account for StrictName usage... #1497
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1497 +/- ##
==========================================
+ Coverage 25.38% 25.45% +0.06%
==========================================
Files 97 97
Lines 4987 4997 +10
==========================================
+ Hits 1266 1272 +6
- Misses 3575 3578 +3
- Partials 146 147 +1
Continue to review full report at Codecov.
|
@c-knowles would you be so kind as to take a look at this for me and let me know if it looks ok to you? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
I was a little confused at first but then realised strictName
is a pre-existing option which is probably why I missed it when cleaning some of this up in #1285.
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: c-knowles The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
When you are using StrictName for IAMRole names then you should have the full 64 characters to play with, but
kube-aws
was still checking the length against the generated name.