Skip to content
This repository has been archived by the owner on Sep 30, 2020. It is now read-only.

IAM Role name length checks need to account for StrictName usage... #1497

Conversation

davidmccormick
Copy link
Contributor

When you are using StrictName for IAMRole names then you should have the full 64 characters to play with, but kube-aws was still checking the length against the generated name.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 20, 2018
@codecov-io
Copy link

Codecov Report

Merging #1497 into master will increase coverage by 0.06%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1497      +/-   ##
==========================================
+ Coverage   25.38%   25.45%   +0.06%     
==========================================
  Files          97       97              
  Lines        4987     4997      +10     
==========================================
+ Hits         1266     1272       +6     
- Misses       3575     3578       +3     
- Partials      146      147       +1
Impacted Files Coverage Δ
pkg/api/cluster.go 0% <0%> (ø) ⬆️
pkg/model/node_pool_config.go 31.7% <0%> (ø) ⬆️
cfnresource/naming.go 81.81% <80%> (-18.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8158496...e8a4b85. Read the comment docs.

@davidmccormick
Copy link
Contributor Author

@c-knowles would you be so kind as to take a look at this for me and let me know if it looks ok to you?

@cknowles cknowles self-requested a review November 28, 2018 08:45
Copy link
Contributor

@cknowles cknowles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

I was a little confused at first but then realised strictName is a pre-existing option which is probably why I missed it when cleaning some of this up in #1285.

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 28, 2018
@cknowles
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: c-knowles

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 28, 2018
@k8s-ci-robot k8s-ci-robot merged commit dc29af4 into kubernetes-retired:master Nov 28, 2018
@davidmccormick davidmccormick deleted the adjust-iam-role-naming-with-strict branch January 2, 2019 11:32
@davidmccormick davidmccormick added this to the v0.13.0 milestone Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants