This repository has been archived by the owner on Sep 30, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 295
Change StackExists behaviour #1499
Merged
k8s-ci-robot
merged 1 commit into
kubernetes-retired:master
from
HotelsDotCom:correct-stack-exists-behavoir
Nov 27, 2018
Merged
Change StackExists behaviour #1499
k8s-ci-robot
merged 1 commit into
kubernetes-retired:master
from
HotelsDotCom:correct-stack-exists-behavoir
Nov 27, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tack does not exist.
k8s-ci-robot
added
the
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
label
Nov 21, 2018
davidmccormick
changed the title
Change StackExists behavoiur
Change StackExists behaviour
Nov 21, 2018
Codecov Report
@@ Coverage Diff @@
## master #1499 +/- ##
=========================================
+ Coverage 25.38% 25.4% +0.01%
=========================================
Files 97 97
Lines 4987 4991 +4
=========================================
+ Hits 1266 1268 +2
- Misses 3575 3577 +2
Partials 146 146
Continue to review full report at Codecov.
|
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: c-knowles The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
label
Nov 27, 2018
/check-cla |
k8s-ci-robot
added
the
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
label
Nov 27, 2018
cknowles
pushed a commit
to cknowles/kube-aws
that referenced
this pull request
Dec 5, 2018
…stack-exists-behavoir Change StackExists behaviour
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
lgtm
Indicates that a PR is ready to be merged.
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@c-knowles when we changed to using
DescribeStacks
instead ofListStacks
it now returns an error if the stack does not exist. This change detects if the error was caused by the stack not existing and returnsfalse
andnil
error instead.This helps prevent errors like when running
validate
orapply
...