Skip to content
This repository has been archived by the owner on Sep 30, 2020. It is now read-only.

CA self-genereted cert: add the cn flag #1512

Merged
merged 1 commit into from
Dec 10, 2018

Conversation

sonant
Copy link
Contributor

@sonant sonant commented Dec 5, 2018

CA self-genereted cert: add the cn flag

all self-signed CA have the samee CN and this can confuse clients like
Chrome. Now we can set different CN

Fixes #463

all self-signed CA have the samee CN and this can confuse clients like
Chrome. Now we can set different CN

Fixes kubernetes-retired#463
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 5, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: danielfm

If they are not already assigned, you can assign the PR to them by writing /assign @danielfm in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-io
Copy link

Codecov Report

Merging #1512 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1512   +/-   ##
=======================================
  Coverage   25.47%   25.47%           
=======================================
  Files          97       97           
  Lines        5001     5001           
=======================================
  Hits         1274     1274           
  Misses       3580     3580           
  Partials      147      147
Impacted Files Coverage Δ
pki/ca.go 0% <0%> (ø) ⬆️
credential/generator.go 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc29af4...d2ce041. Read the comment docs.

@davidmccormick
Copy link
Contributor

This looks ok to me

@davidmccormick
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 10, 2018
@davidmccormick davidmccormick merged commit 1a33688 into kubernetes-retired:master Dec 10, 2018
@davidmccormick
Copy link
Contributor

Thanks very much for your effort on this!

kevtaylor pushed a commit to HotelsDotCom/kube-aws that referenced this pull request Jan 9, 2019
all self-signed CA have the samee CN and this can confuse clients like
Chrome. Now we can set different CN

Fixes kubernetes-retired#463
@davidmccormick davidmccormick added this to the v0.13.0 milestone Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants