Skip to content
This repository has been archived by the owner on Sep 30, 2020. It is now read-only.

[v0.13.x] Fix formatting with cluster-autoscaler #1655

Merged
merged 1 commit into from
Jun 28, 2019
Merged

[v0.13.x] Fix formatting with cluster-autoscaler #1655

merged 1 commit into from
Jun 28, 2019

Conversation

dominicgunn
Copy link
Contributor

@dominicgunn dominicgunn commented Jun 28, 2019

Changes

  • Fixes the formatting used by the Go Templates when creating the option set for cluster-autoscaler, with the current setup the formatting will indent the text too far as shown below.
- --expander=least-waste
              - --a=b
              - --c=d

Bumping them a little to the right fixes the formatting.

Resolves #1653

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 28, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign dominicgunn
You can assign the PR to them by writing /assign @dominicgunn in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 28, 2019
@dominicgunn dominicgunn added this to the v0.13.0-rc.3 milestone Jun 28, 2019
@codecov-io
Copy link

Codecov Report

Merging #1655 into v0.13.x will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           v0.13.x    #1655   +/-   ##
========================================
  Coverage    25.49%   25.49%           
========================================
  Files           98       98           
  Lines         5049     5049           
========================================
  Hits          1287     1287           
  Misses        3619     3619           
  Partials       143      143

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0af831a...cb71745. Read the comment docs.

@davidmccormick davidmccormick merged commit 095a844 into kubernetes-retired:v0.13.x Jun 28, 2019
@dominicgunn dominicgunn deleted the v0.13.x-cluster-autoscaler-options branch June 28, 2019 12:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants