Validate Karpenter Disruption taints as part of preStop node evaluation

[alexandermarston]

Is this a bug fix or adding new feature?

Bug Fix

What is this PR about? / Why do we need it?

Fix for #1955

Karpenter introduced a breaking change in kubernetes-sigs/karpenter#508 which means it now uses the karpenter.sh/disrupting taint instead of the node.kubernetes.io/unschedulable taint when deprovisioning nodes, which means the preStop code will not run.

This PR adds another check for the new Karpenter taint, instead of only looking for node.kubernetes.io/unschedulable.

What testing is done?

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: alexandermarston / name: Alex Marston (f725f72, c28fe17)

[k8s-ci-robot]

Welcome @alexandermarston!

It looks like this is your first PR to kubernetes-sigs/aws-ebs-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-ebs-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @alexandermarston. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[AndrewSirenko]

Thank you for this @alexandermarston /ok-to-test

[alexandermarston]

/test

[k8s-ci-robot]

@alexandermarston: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[torredil]

/ok-to-test

[ConnorJC3]

/lgtm

[github-actions]

Code Coverage Diff

File	Old Coverage	New Coverage	Delta
github.com/kubernetes-sigs/aws-ebs-csi-driver/cmd/hooks/prestop.go	82.4%	81.1%	-1.2

[AndrewSirenko]

Looks great to me, thank you for the fix and extra unit tests.

[torredil]

Thank you! @alexandermarston
/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: torredil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [torredil]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment