Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update mkdocs dependencies #3803

Merged
merged 1 commit into from
Aug 12, 2024
Merged

update mkdocs dependencies #3803

merged 1 commit into from
Aug 12, 2024

Conversation

M00nF1sh
Copy link
Collaborator

Issue

N/A

Description

update mkdocs dependencies to latest since the current ones were broken

Manually verified new page looks good overall

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the docs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 12, 2024
@oliviassss
Copy link
Collaborator

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 12, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: M00nF1sh, oliviassss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [M00nF1sh,oliviassss]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@M00nF1sh M00nF1sh merged commit 9e2cbe7 into kubernetes-sigs:main Aug 12, 2024
6 of 9 checks passed
zac-nixon pushed a commit to zac-nixon/aws-load-balancer-controller that referenced this pull request Sep 3, 2024
@M00nF1sh @zac-nixon
update mkdocs dependencies (kubernetes-sigs#3803)
8b9ea89
zac-nixon pushed a commit to zac-nixon/aws-load-balancer-controller that referenced this pull request Sep 4, 2024
@M00nF1sh @zac-nixon
update mkdocs dependencies (kubernetes-sigs#3803)
c000f89
@shraddhabang shraddhabang mentioned this pull request Sep 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johngmyers johngmyers Awaiting requested review from johngmyers

@oliviassss oliviassss Awaiting requested review from oliviassss

Assignees

@oliviassss oliviassss

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@M00nF1sh @oliviassss @k8s-ci-robot