Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update asciinema tutorial to use mage not compile-release-tools #367

Closed
pnasrat opened this issue Nov 6, 2023 · 4 comments · Fixed by #411
Closed

Update asciinema tutorial to use mage not compile-release-tools #367

pnasrat opened this issue Nov 6, 2023 · 4 comments · Fixed by #411
Labels
kind/bug Categorizes issue or PR as related to a bug. kind/documentation Categorizes issue or PR as related to documentation. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. sig/release Categorizes an issue or PR as relevant to SIG Release.

Comments

@pnasrat
Copy link
Contributor

pnasrat commented Nov 6, 2023

/kind documentation

What happened:

I was checking out bom and the instructions in the asciinema for building the tool are incorrect.

Following kubernetes/release@9d20564#diff-6b680f315f5f071ad9a14ff82bfcf67880a01f26e03cafbb8bd2553a5c1b6ddd the asciinema tutorial is misleading as it mentions ./compile-release-tools which no longer supports bom

Based upon reading the github workflow config the current way for a local build should be go run mage.go buildBinariesSnapshot

What you expected to happen:

Documentation containing build instructions works

@pnasrat pnasrat added kind/bug Categorizes issue or PR as related to a bug. sig/release Categorizes an issue or PR as relevant to SIG Release. labels Nov 6, 2023
@k8s-ci-robot k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Nov 6, 2023
@cpanato
Copy link
Member

cpanato commented Nov 8, 2023

Thanks, are you willing to open a PR to fix that?

@pnasrat
Copy link
Contributor Author

pnasrat commented Nov 9, 2023

@cpanato I can write a PR to add the Documentation on how to build, and then see if I can get a reasonable version of a screencast if that's something the project wants to retain in the README

@cpanato
Copy link
Member

cpanato commented Dec 12, 2023

i think the screencast we can drop, wdyt @puerco ?

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. kind/documentation Categorizes issue or PR as related to documentation. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. sig/release Categorizes an issue or PR as relevant to SIG Release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants