-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gcp_janitor.py: cleanup security-policies #181
gcp_janitor.py: cleanup security-policies #181
Conversation
sawsa307
commented
Jan 12, 2024
- Add security-policies to the list of resources for cleanup.
- Cleanup should be done for both regional and glocal policies.
- Security policies have dependencies on backend services, target pools, target instances, and instances. Thus, its cleanup should be after the cleanups of these resources.
* Add security-policies to the list of resources for cleanup. * Cleanup should be done for both regional and glocal policies. * Security policies have dependencies on backend services, target pools, target instances, and instances. Thus, its cleanup should be after the cleanups of these resources.
Hi @sawsa307. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Tested locally with internal prow projects. |
/assign @krzyzacy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: krzyzacy, sawsa307 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |