Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(helm): publish cloud-provider-azure chart 1.23.11 #1640

Merged
merged 1 commit into from May 5, 2022
Merged

chore(helm): publish cloud-provider-azure chart 1.23.11 #1640

merged 1 commit into from May 5, 2022

Conversation

jackfrancis
Copy link
Contributor

What type of PR is this?

This PR updates the helm 1.23.11 chart release so that versions of cloud-provider-azure are automatically updated when installed onto a cluster bases on the installed version of Kubernetes.

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 2, 2022
jackfrancis
jackfrancis commented May 2, 2022
View reviewed changes
helm/cloud-provider-azure/templates/cloud-provider-azure.yaml
@@ -1,9 +1,9 @@
{{- if eq .Capabilities.KubeVersion.Minor "21" -}}
{{- $_ := set . "cloudProviderAzureVersion" "v1.0.17" }}
{{- $_ := set . "cloudProviderAzureVersion" "v1.0.18" }}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI @feiskyer these are the values that need to be changed when we cut new releases of cloud-provider-azure. We want to keep the imageTag values commented out so that we don't provide a default. The imageTag configuration is mean to be a user-provided override when using a custom image reference.

Thanks for doing this work as part of the release! (I'm happy to follow releases and maintain this myself if you'd like, but also happy for you to do them and for me to observe/lgtm as appropriate).

@coveralls
Copy link

coveralls commented May 2, 2022 •
edited

Coverage Status

Coverage remained the same at 80.466% when pulling eed8e56 on jackfrancis:helm-1.23.11 into a6b5a5c on kubernetes-sigs:master.

jackfrancis
jackfrancis commented May 2, 2022
View reviewed changes
hack/update-helm-repo.sh
@@ -19,5 +19,8 @@ set -o pipefail

REPO_ROOT=$(dirname "${BASH_SOURCE}")/..

helm package ${REPO_ROOT}/helm/cloud-provider-azure -d ${REPO_ROOT}/helm/repo
helm repo index ${REPO_ROOT}/helm/repo
helm package ${REPO_ROOT}/helm/cloud-provider-azure -d ${REPO_ROOT}/helm/repo/new
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR also updates the helm repo foo so that we don't overwrite the created timestamp for a version every time we publish a new release.

See this thread:

helm/helm#7363

@jackfrancis
Copy link
Contributor Author

/retest

1 similar comment
@jackfrancis
Copy link
Contributor Author

/retest

@jackfrancis
Copy link
Contributor Author

@andyzhangx are you able to review this?

@MartinForReal
Copy link
Contributor

/kind cleanup

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed do-not-merge/needs-kind labels May 5, 2022
@MartinForReal
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 5, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, MartinForReal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 5, 2022
andyzhangx
andyzhangx reviewed May 5, 2022
View reviewed changes
helm/cloud-provider-azure/values.yaml
@@ -14,7 +14,7 @@ cloudControllerManager:
# http2MaxStreamsPerConnection: "47"
imageRepository: "mcr.microsoft.com/oss/kubernetes"
imageName: "azure-cloud-controller-manager"
imageTag: "v1.23.11"
#imageTag: "v1.23.11"
Copy link
Member

@andyzhangx andyzhangx May 5, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why comment it here?

@MartinForReal MartinForReal mentioned this pull request May 5, 2022
Merged
@MartinForReal MartinForReal merged commit 5ddb989 into kubernetes-sigs:master May 5, 2022
@MartinForReal
Copy link
Contributor

merged because there are no test cases in e2e test suite which is focused on helm chart

seung-moon added a commit to seung-moon/cloud-provider-azure that referenced this pull request May 15, 2022
@seung-moon
Revert "Merge pull request kubernetes-sigs#1640 from jackfrancis/helm…
d0cc354 
…-1.23.11"

This reverts commit 5ddb989, reversing
changes made to b2eb7f7.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyzhangx andyzhangx andyzhangx left review comments

@feiskyer feiskyer Awaiting requested review from feiskyer

Assignees

@MartinForReal MartinForReal

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jackfrancis @coveralls @MartinForReal @k8s-ci-robot @andyzhangx