[release-1.1] Deepcopy results of cache Get() #2705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lzhecheng The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
lzhecheng
force-pushed
the
cp-2445-1.1
branch
3 times, most recently
from
8eb939a
to
e1f4587
Compare
lzhecheng
force-pushed
the
cp-2445-1.1
branch
from
e1f4587
to
6fd458f
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/retest |
|
/test pull-cloud-provider-azure-unit-1-22 |
|
@lzhecheng Should we ignore all test for kubetest2? |
lzhecheng
force-pushed
the
cp-2445-1.1
branch
from
6fd458f
to
f136b29
Compare
k8s-ci-robot
removed
the
lgtm
What are the kubetest2 tests? I don't see any. |
Considering thread safety, results of cache Get() should be deepcopied before used. * Support deepcopy and add UT for all types * Add TestGet UT * Update current UT * Make Entry structs exported to adjust for deepcopy * Delete cacheKey for VMSS VM and VMSS deletion Signed-off-by: Zhecheng Li <zhechengli@microsoft.com>
lzhecheng
force-pushed
the
cp-2445-1.1
branch
from
f136b29
to
6be6850
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Zhecheng Li zhechengli@microsoft.com
What type of PR is this?
/kind bug
What this PR does / why we need it:
[release-1.1] Deepcopy results of cache Get()
Considering thread safety, results of cache Get() should be deepcopied before used.
#2445
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: