New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add projected sa token config #4809
add projected sa token config #4809
Conversation
@sonasingh46 Could you please update the readme as well? I think additional config for workload identity is required if we want to enable workload identity for cloud provider. |
ea0e712
to
a2c8432
Compare
@MartinForReal -- How can I fix the |
/assign @lzhecheng |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just noticed an existing chart is bumped in this PR. Could you bump the chart version and re-generate again?
/lgtm cancel
Signed-off-by: Ashutosh Kumar <sonasingh46@gmail.com>
7fddf60
to
a016c05
Compare
@feiskyer -- Done |
/lgtm |
/retest |
/kind feature |
@lzhecheng @feiskyer PTAL this is blocking CAPZ workload identity |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lzhecheng, sonasingh46 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@sonasingh46 we are hitting lots of following errors in the csi driver e2e test:
it's on v1.25.6, how can I overcome this issue? |
ok, I see it's fixed by #4921 |
What this PR does / why we need it:
This PR adds helm config to project service account token for cloud controller manager which is required for workload identity.
Which issue(s) this PR fixes:
Partially Fixes kubernetes-sigs/cluster-api-provider-azure#3589
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: