Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add AllowBlobPublicAccess setting in storage account creation #784

Merged
merged 1 commit into from Aug 31, 2021
Merged

feat: add AllowBlobPublicAccess setting in storage account creation #784

merged 1 commit into from Aug 31, 2021

Conversation

andyzhangx
Copy link
Member

What type of PR is this?

/kind feature

What this PR does / why we need it:

feat: add AllowBlobPublicAccess setting in storage account creation
This PR also add ctx context.Context parameter in some functions.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

feat: add AllowBlobPublicAccess setting in storage account creation

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

feat: add AllowBlobPublicAccess setting in storage account creation

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 31, 2021
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 31, 2021
@andyzhangx
Copy link
Member Author

/retest

@mukhoakash mukhoakash mentioned this pull request Aug 31, 2021
Closed
ZeroMagic
ZeroMagic approved these changes Aug 31, 2021
View reviewed changes
Copy link
Member

@ZeroMagic ZeroMagic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 31, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, ZeroMagic

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 2e6c2a2 into kubernetes-sigs:master Aug 31, 2021
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 80.581% when pulling 5adee06 on andyzhangx:AllowBlobPublicAccess into 692d51e on kubernetes-sigs:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeroMagic ZeroMagic ZeroMagic approved these changes

@feiskyer feiskyer Awaiting requested review from feiskyer

@nilo19 nilo19 Awaiting requested review from nilo19

Assignees

@ZeroMagic ZeroMagic

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@andyzhangx @k8s-ci-robot @coveralls @ZeroMagic