Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kustomize Patch Support for coredns-operator base manifests #12

Closed
stealthybox opened this issue Jun 14, 2019 · 3 comments
Closed

Kustomize Patch Support for coredns-operator base manifests #12

stealthybox opened this issue Jun 14, 2019 · 3 comments

Comments

@stealthybox
Copy link
Contributor

Users should be able to include arbitrary patches to operator resources.
One use-case would be to mutate the Service to annotate it for an ingress-controller.

@johnsonj is working on implementing Kustomize style patch support:

justinsb#1
kubernetes-sigs/kubebuilder-declarative-pattern#44

We should get the operator side of things merged into #7 either in justin's repo before merge.
We can also just re-open the PR on this repo which unblocks merging #7.

@dholbach
Copy link
Member

@johnsonj In #18 you say that it updates this issue. Could we break down what needs to be done here?

@johnsonj
Copy link
Contributor

I think this should be closed at this point. There's lots of ways forward for patching but I believe the exploratory CL covers this issue.

@dholbach
Copy link
Member

Super, thanks @johnsonj!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants