Example core-dns operator using declarative pattern

[justinsb]

Strawman for discussion in meeting tomorrow!

cc @dholbach

[dholbach]

Thanks for your work on this @justinsb!

I tried playing around with this. Could it be that a Dockerfile is missing (make docker-build)?

[stealthybox]

I got it running

mkdir -p $GOPATH/src/sigs.k8s.io/
cd $GOPATH/src/sigs.k8s.io/
git clone git@github.com:kubernetes-sigs/addon-operators.git
hub checkout https://github.com/kubernetes-sigs/addon-operators/pull/7

export GO111MODULE=on
go mod download
go mod vendor

make
kind create cluster --image kindest/node:v1.14.0
make install

~/go/src/sigs.k8s.io/addon-operators/coredns strawman_coredns* 6s
❯ k get crd
NAME                    CREATED AT
coredns.addons.k8s.io   2019-04-30T15:43:43Z

~/go/src/sigs.k8s.io/addon-operators/coredns strawman_coredns*
❯ k get coredns.addons.k8s.io
No resources found.

[johnsonj]

I've added an example of Patch (as in kustomize patch) to this operator: justinsb#1

[stealthybox]

/lgtm

@justinsb @johnsonj @dholbach :
I think we should merge this implementation.
I like that it works from a manifests as a starting point.
IMHO, we should work on making that backend pluggable next (ie: cluster bundle / git / ORAS).
That will move us toward tools and libs that can be used by cluster-management tools to install the operators/rbac as well.

@johnsonj maybe re-open justinsb#1 on this repo after we merge this?

[k8s-ci-robot]

@stealthybox: changing LGTM is restricted to assignees, and only kubernetes-sigs/addon-operators repo collaborators may be assigned issues.

In response to this:

/lgtm

@justinsb @johnsonj @dholbach :
I think we should merge this implementation.
I like that it works from a manifests as a starting point.
IMHO, we should work on making that backend pluggable next (ie: cluster bundle / git / ORAS).
That will move us toward tools and libs that can be used by cluster-management tools to install the operators/rbac as well.

@johnsonj maybe re-open justinsb#1 on this repo after we merge this?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dholbach]

Can we merge this, or is there more feedback to be resolved first?

[atoato88]

I'm interested in this PR and checked that works on my env.
But this PR doesn't have a test like "Golden File Tests".
I would like to add it after merged this PR, is it OK?

[johnsonj]

Sounds good to me!

…

On Wed, Jun 19, 2019, 1:31 PM atoato88 ***@***.***> wrote: I'm interested in this PR and checked that works on my env. But this PR doesn't have a test like "Golden File Tests" <https://github.com/kubernetes-sigs/kubebuilder-declarative-pattern/blob/master/docs/addon/walkthrough/tests.md#golden-file-tests> . I would like to add it after merged this PR, is it OK? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#7>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AADGRZP4BN2WTYVFEMP766LP3KJSFANCNFSM4HJEYNOA> .

[justinsb]

Removed the WIP label. Does someone want to add lgtm and start our engines? :-)

[stealthybox]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, stealthybox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [justinsb,stealthybox]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[stealthybox]

/lgtm

[stealthybox]

Does someone want to add lgtm and start our engines? :-)

Let the games begin! 🎉 💥

[johnsonj]

awesome!

/lgtm