Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Centralize Documentations and README.md #78

Merged
merged 3 commits into from
Sep 4, 2020

Conversation

somtochiama
Copy link
Member

This pull request is for centralizing the documentation in cluster-addons and making the documentation more interesting and clearer to whoever is poking around. Reviews and suggestions are welcome from everyone @rajansandeep @dholbach @stealthybox @justinsb .

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 21, 2020
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 21, 2020
@dholbach
Copy link
Member

/cc @justinsb @stealthybox

README.md Outdated Show resolved Hide resolved
Co-authored-by: Daniel Holbach <daniel@weave.works>
Copy link
Contributor

@rajansandeep rajansandeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good!

dashboard/README.md Outdated Show resolved Hide resolved
Co-authored-by: Sandeep Rajan <srajan@infoblox.com>
@justinsb
Copy link
Contributor

justinsb commented Sep 4, 2020

I like this approach - thanks @somtochiama

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 4, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, SomtochiAma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 4, 2020
@k8s-ci-robot k8s-ci-robot merged commit 782fef2 into kubernetes-sigs:master Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants