-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add managed DNS record support for API endpoint #232
Add managed DNS record support for API endpoint #232
Conversation
Hi @gottwald. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
eb28316
to
d111f36
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just did some testing with this feature and the functionality is work as expected.
I left some comment.
@prksu PTAL again; please also note that I added a DNS verification thingy which covers an edge case when DNS entry is not propagated, yet. I pushed roughly the same time as you reviewed, so you might not have seen this part, yet. |
@@ -0,0 +1,61 @@ | |||
/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can move this file to another directory like utils
in the future. But leave it as is for now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gottwald, prksu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This adds an optional feature to include a managed DNS record that points to the KAS LB and is used as control plane API endpoint in all configs and certs. This makes the IP of the load-balancer interchangeable and makes losing the (ephemeral) LB IP much less fatal to the cluster setup.
It is backwards compatible: meaning if the record is not set, the LB IP is used as it was before.
A transition from IP-based to DNS-based endpoint is not supported in this iteration. A feature like this would also likely need changes in cluster-api itself.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #231
Special notes for your reviewer:
This probably deserves an extension of the e2e test and should be fairly easy to do so, but the e2e environment would need a set up test domain in the e2e DO account to do so. I have no access to that.
Documentation:
Release note: