Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cluster UID in Loadbalancer name and Droplet target tag #233

Merged
merged 1 commit into from
Feb 5, 2021

Conversation

prksu
Copy link
Contributor

@prksu prksu commented Jan 29, 2021

What this PR does / why we need it:
This PR adds Cluster UID in Loadbalancer name and adds an additional tag that contains Cluster UID for droplet target tag to allow creating two or more clusters with the same name but different namespace in the single management cluster.

Which issue(s) this PR fixes:
Fixes #217

Special notes for your reviewer:
/cc @timoreimann

Release note:

Add Cluster UID in Loadbalancer name and Droplet target tag

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 29, 2021
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: prksu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 29, 2021
Copy link
Contributor

@timoreimann timoreimann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me in general.

@prksu should we try to accompany the change with an e2e test to guarantee it's working for sure?
I realize this would effectively implement #185. If that sounds like too much work, we could also punt on that for now (but should probably have one before the next release IMO), and maybe do a quick manual test instead. WDYT?

@prksu
Copy link
Contributor Author

prksu commented Feb 1, 2021

@timoreimann so far I just do a manual test and it works as expected.

$ kubectl get cluster -A
NAMESPACE   NAME               PHASE
default     capdo-quickstart   Provisioned
dev         capdo-quickstart   Provisioned
$ doctl compute load-balancer list --format ID,Name,Status,Tag
ID                                      Name                                                               Status    Tag
aca64495-63b9-48c6-9ea9-59d9df65c45d    capdo-quickstart-apiserver-f7777de0-315c-466d-a9de-07121680b75f    active    sigs-k8s-io:capdo:capdo-quickstart:f7777de0-315c-466d-a9de-07121680b75f:apiserver
5309ee41-34ea-4e3d-9802-a955af256156    capdo-quickstart-apiserver-b72a8475-c71e-4fe4-b73a-b98c81afcf0c    active    sigs-k8s-io:capdo:capdo-quickstart:b72a8475-c71e-4fe4-b73a-b98c81afcf0c:apiserver

And yes, it would be good to add e2e for this, let's make e2e as a follow-up. the test would be creating two capdo clusters with the same cluster-name in the different namespace.
actually, #185 is for LB creation from Service (created by CCM), the LB creation for control-plane itself already covered in current e2e.

@timoreimann
Copy link
Contributor

@prksu makes total sense to me. Thanks a bunch for driving this one. 👍

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 5, 2021
@k8s-ci-robot k8s-ci-robot merged commit 6267e4b into kubernetes-sigs:master Feb 5, 2021
@k8s-ci-robot k8s-ci-robot added this to the v0.4 milestone Feb 5, 2021
@prksu prksu deleted the add-cluster-uid branch March 19, 2021 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cannot run two clusters in different namespaces but equal names due to existing LB configuration
3 participants