Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add webhook for IBMPowerVS resources #488

Merged
merged 1 commit into from
Dec 16, 2021
Merged

Add webhook for IBMPowerVS resources #488

merged 1 commit into from
Dec 16, 2021

Conversation

Prajyot-Parab
Copy link
Contributor

@Prajyot-Parab Prajyot-Parab commented Dec 14, 2021 •
edited
Loading

Signed-off-by: Prajyot-Parab prajyot.parab2@ibm.com

What this PR does / why we need it:

  1. Add Webhooks with default and validation logic for IBMPowerVS* resources.
  2. TODO - Add Webhooks with default and validation logic for IBMVPC* resources.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #434

Special notes for your reviewer:

/area provider/ibmcloud

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

@k8s-ci-robot k8s-ci-robot added area/provider/ibmcloud Issues or PRs related to ibmcloud provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 14, 2021
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Dec 14, 2021 •
edited
Loading

CLA Signed

The committers are authorized under a signed CLA.

@netlify
Copy link

netlify bot commented Dec 14, 2021 •
edited
Loading

✔️ Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!

🔨 Explore the source changes: f475f98

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-sigs-cluster-api-ibmcloud/deploys/61bad48cb814a4000858227c

😎 Browse the preview: https://deploy-preview-488--kubernetes-sigs-cluster-api-ibmcloud.netlify.app

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 14, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @Prajyot-Parab. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Dec 14, 2021
@mkumatag
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 14, 2021
mkumatag
mkumatag requested changes Dec 14, 2021
View reviewed changes
api/v1beta1/ibmpowervscluster_webhook.go Outdated Show resolved Hide resolved
api/v1beta1/ibmpowervscluster_webhook.go Outdated Show resolved Hide resolved
api/v1beta1/ibmpowervscluster_webhook.go Outdated Show resolved Hide resolved
api/v1beta1/ibmpowervsmachine_webhook.go Outdated Show resolved Hide resolved
config/crd/patches/webhook_in_ibmpowervsclusters.yaml Outdated Show resolved Hide resolved
config/crd/patches/webhook_in_ibmpowervsmachines.yaml Outdated Show resolved Hide resolved
config/crd/patches/webhook_in_ibmpowervsmachinetemplates.yaml Outdated Show resolved Hide resolved
main.go Show resolved Hide resolved
@Prajyot-Parab
Add webhook for IBMPowerVS resources
f475f98 
Signed-off-by: Prajyot-Parab <prajyot.parab2@ibm.com>
mkumatag
mkumatag approved these changes Dec 16, 2021
View reviewed changes
Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 16, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mkumatag, Prajyot-Parab

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 16, 2021
@k8s-ci-robot k8s-ci-robot merged commit 7d78ed5 into kubernetes-sigs:main Dec 16, 2021
@Prajyot-Parab Prajyot-Parab mentioned this pull request Feb 4, 2022
Closed
9 tasks
@Prajyot-Parab Prajyot-Parab deleted the webhook branch June 10, 2022 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkumatag mkumatag mkumatag approved these changes

@gyliu513 gyliu513 Awaiting requested review from gyliu513

@jichenjc jichenjc Awaiting requested review from jichenjc

Assignees

@mkumatag mkumatag

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/ibmcloud Issues or PRs related to ibmcloud provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Introduce the webhook
3 participants
@Prajyot-Parab @k8s-ci-robot @mkumatag