Let users select provider OS #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
size/M
hidekazuna
reviewed
Nov 1, 2018
| @@ -12,8 +12,14 @@ print_help() | |||
| echo "-h, --help show brief help" | |||
| echo "-f, --force-overwrite if file to be generated already exists, force script to overwrite it" | |||
| echo "-c, --clouds [File] specifies an existing clouds.yaml file to use rather than generating one interactively" | |||
| echo "--provider-os [os name] select the operating system of your provider environment" | |||
| echo " Supported Operating Systems: ubuntu, centos" | |||
There was a problem hiding this comment.
This script ended with error without --provider-os option. Please add "Mandatory"
| } | ||
|
|
||
| # Supported Operating Systems | ||
| declare -a arr=("centos" "ubuntu") | ||
|
|
||
| SCRIPT=$(basename $0) | ||
| while test $# -gt 0; do |
There was a problem hiding this comment.
--provider-os is mandatory. Please take care of it.
…erate-yaml script Referencing: kubernetes-sigs#88 :)
|
@hidekazuna the issue has been resolved. Thanks for the review! |
hidekazuna
reviewed
Nov 2, 2018
|
/assign @dims It was the robots idea: "We suggest the following additional approver: dims" |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, iamemilio The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/retest |
Merged
k8s-ci-robot
pushed a commit
that referenced
this pull request
Nov 20, 2018
* Fix README.md Required option --provider-os was added to generate-yaml.sh in #90. This patch fixes Cluster Creation section in README.md. * Apply suggestions from code review Co-Authored-By: hidekazuna <hidekazuna@gmail.com>
ainmosni
pushed a commit
to ainmosni/cluster-api-provider-openstack
that referenced
this pull request
Nov 23, 2018
* Fix README.md Required option --provider-os was added to generate-yaml.sh in kubernetes-sigs#90. This patch fixes Cluster Creation section in README.md. * Apply suggestions from code review Co-Authored-By: hidekazuna <hidekazuna@gmail.com>
flaper87
referenced
this pull request
in openshift/cluster-api-provider-openstack
Nov 29, 2018
* Fix README.md Required option --provider-os was added to generate-yaml.sh in #90. This patch fixes Cluster Creation section in README.md. * Apply suggestions from code review Co-Authored-By: hidekazuna <hidekazuna@gmail.com>
u5surf
pushed a commit
to u5surf/cluster-api-provider-openstack
that referenced
this pull request
Nov 30, 2018
* Fix README.md Required option --provider-os was added to generate-yaml.sh in kubernetes-sigs#90. This patch fixes Cluster Creation section in README.md. * Apply suggestions from code review Co-Authored-By: hidekazuna <hidekazuna@gmail.com>
iamemilio
pushed a commit
to iamemilio/cluster-api-provider-openstack
that referenced
this pull request
Jun 18, 2020
Bug 1810400: Port CAPO to MAO API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables users to select which provider os they want to use in the generate-yaml.sh script
Referencing: #88
Special Notes:
:)