remove the projectID from PacketMachine crd #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It does not look like the PacketMachine needs a ProjectID. It is a value that we get from the PacketCluster. It is not even generated from the `make examples` file and when applied via kubectl it fails because PachetMachine.ProjectID is a required field in openapi.
|
@deitch can you validate my assumption and the change itself? |
I think you are correct. I am looking at the change itself. |
|
I approved the PR, but it looks like CI is failing due to some weird controller-gen stuff. Since this is a development branch, it isn't worth holding it up, but we should get that fixed too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It does not look like the PacketMachine needs a ProjectID. It is a value
that we get from the PacketCluster.
It is not even generated from the
make examplesfile and when appliedvia kubectl it fails because PachetMachine.ProjectID is a required field
in openapi.