✨Add defaulting webhooks to cluster api manager #1824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
wfernandes
commented
Dec 3, 2019
detiber
reviewed
Dec 3, 2019
wfernandes
commented
Dec 3, 2019
wfernandes
force-pushed
the
defaulting-webhook
branch
2 times, most recently
from
8b0b261
to
49bdce0
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
ncdc
reviewed
Dec 3, 2019
wfernandes
force-pushed
the
defaulting-webhook
branch
from
49bdce0
to
307ac65
Compare
k8s-ci-robot
removed
the
lgtm
wfernandes
force-pushed
the
defaulting-webhook
branch
3 times, most recently
from
37fc969
to
08e9fe6
Compare
ncdc
suggested changes
Dec 4, 2019
detiber
reviewed
Dec 4, 2019
wfernandes
force-pushed
the
defaulting-webhook
branch
from
08e9fe6
to
eec0321
Compare
k8s-ci-robot
added
size/XL
wfernandes
commented
Dec 5, 2019
Sets appropriate defaults to cluster, machine and machine deployment objects. Validates namespace match those of reference objects. Signed-off-by: Warren Fernandes <wfernandes@pivotal.io>
wfernandes
force-pushed
the
defaulting-webhook
branch
from
eec0321
to
7950aac
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ncdc, wfernandes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds appropriate default mutating webhooks to cluster, machine and
machine deployment objects.
Signed-off-by: Warren Fernandes wfernandes@pivotal.io
What this PR does / why we need it:
This PR adds mutating webhooks for Cluster, Machine and MachineDeployments to provide appropriate defaults for the respective objects.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #1794