Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚠️ Support go-logr/logr@v0.2.0 #1011

Closed
wants to merge 2 commits into from
Closed

⚠️ Support go-logr/logr@v0.2.0 #1011

wants to merge 2 commits into from

Conversation

zchee
Copy link
Contributor

@zchee zchee commented Jun 19, 2020 •
edited
Loading

Support go-logr/logr to the latest version.

The go-logr/logr package has been removed logr.InfoLogger, fixed pkg/log.nullLogger.V return type to logr.Logger.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 19, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @zchee!

It looks like this is your first PR to kubernetes-sigs/controller-runtime 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/controller-runtime has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @zchee. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 19, 2020
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 19, 2020
@zchee
Copy link
Contributor Author

zchee commented Jun 19, 2020

/assign @alvaroaleman @DirectXMan12

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zchee
To complete the pull request process, please assign directxman12
You can assign the PR to them by writing /assign @directxman12 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@alvaroaleman
Copy link
Member

There is already #995 for this

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 22, 2020
@DirectXMan12
Copy link
Contributor

This is a breaking change and needs to be marked as such

@zchee
go.mod: update github.com/go-logr/{logr,zapr} to v0.2.0
20567e6 
Signed-off-by: Koichi Shiraishi <zchee.io@gmail.com>
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 23, 2020
@zchee
⚠️ pkg/log: fix V return type to logr.Logger
46812d3 
Signed-off-by: Koichi Shiraishi <zchee.io@gmail.com>
@zchee zchee changed the title Support go-logr/logr to latest ⚠️ Support go-logr/logr to latest Jun 23, 2020
@zchee
Copy link
Contributor Author

zchee commented Jun 23, 2020

@DirectXMan12 marked

@vincepri
Copy link
Member

/milestone Next

@k8s-ci-robot k8s-ci-robot added this to the Next milestone Jun 24, 2020
@vincepri vincepri mentioned this pull request Jun 24, 2020
Closed
@milos-matijasevic milos-matijasevic mentioned this pull request Jul 7, 2020
Closed
@RafalSkolasinski RafalSkolasinski mentioned this pull request Jul 9, 2020
Closed
19 tasks
@abursavich abursavich mentioned this pull request Jul 18, 2020
Closed
@zchee
Copy link
Contributor Author

zchee commented Jul 20, 2020

@DirectXMan12 @alvaroaleman @vincepri
Sorry, just question, When /milestone Next mean?

@vincepri
Copy link
Member

/milestone v0.7.x

@k8s-ci-robot k8s-ci-robot modified the milestones: Next, v0.7.x Jul 21, 2020
@zchee
Copy link
Contributor Author

zchee commented Jul 21, 2020

@vincepri thanks!

@vincepri
Copy link
Member

@zchee I missed your question above, Next is usually a placeholder, I just created v0.7 today

@zchee
Copy link
Contributor Author

zchee commented Jul 21, 2020

@vincepri
oh, I understand all you said means! thanks for polite reply :)

@zchee zchee changed the title ⚠️ Support go-logr/logr to latest ⚠️ Support go-logr/logr@v0.2.0 Jul 23, 2020
@micnncim micnncim mentioned this pull request Jul 29, 2020
Closed
@justenwalker
Copy link

This is a breaking change and needs to be marked as such

go-logr/logr#20 was merged today which adds backward compatibility with logr-0.1.0; possibly making this change non-breaking if this is built against the next release tag.

@zchee
Copy link
Contributor Author

zchee commented Jul 30, 2020

@vincepri Should I update logr?

@zchee
Copy link
Contributor Author

zchee commented Jul 30, 2020

ah, logr not dump new tag yet

@davidkarlsen davidkarlsen mentioned this pull request Aug 3, 2020
Closed
@alvaroaleman
Copy link
Member

We bumped this as part of the kube 1.19 PR: #1068
/close

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 4, 2020
@k8s-ci-robot
Copy link
Contributor

@zchee: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

@alvaroaleman: Closed this PR.

In response to this:

We bumped this as part of the kube 1.19 PR: #1068
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zchee zchee deleted the logr-support-latest branch August 5, 2020 05:58
@shamsher31 shamsher31 mentioned this pull request Aug 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@droot droot Awaiting requested review from droot

@joelanford joelanford Awaiting requested review from joelanford

Assignees

@DirectXMan12 DirectXMan12

@alvaroaleman alvaroaleman

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v0.7.x
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@zchee @k8s-ci-robot @alvaroaleman @DirectXMan12 @vincepri @justenwalker