Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚠️ Update go-logr/logr v0.1.0 -> v0.2.0 #995

Closed
wants to merge 1 commit into from
Closed

⚠️ Update go-logr/logr v0.1.0 -> v0.2.0 #995

wants to merge 1 commit into from

Conversation

micnncim
Copy link
Contributor

@micnncim micnncim commented Jun 13, 2020 •
edited
Loading

What

go-logr has been updated to v0.2.0, including incompatible change, so we cannot use both go-logr v0.2.0 and controller-runtime v0.6.0 simultaneously.

This PR updates go-logr version so that we can use controller-runtime with go-logr v0.2.0.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 13, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @micnncim. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: micnncim
To complete the pull request process, please assign gerred
You can assign the PR to them by writing /assign @gerred in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@micnncim micnncim changed the title ⚠️ Update go-logr/logr v0.1.0 -> v0.2.0 ⚠️ Update go-logr/logr v0.1.0 -> v0.2.0 Jun 13, 2020
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 13, 2020
@micnncim
Copy link
Contributor Author

/assign @gerred

@micnncim
Copy link
Contributor Author

@gerred What do you think about this?

@vincepri
Copy link
Member

Probably need to wait for the next breaking release

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 20, 2020
@k8s-ci-robot
Copy link
Contributor

@micnncim: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@alvaroaleman alvaroaleman mentioned this pull request Jun 21, 2020
Closed
@justenwalker
Copy link

If this upstream patch gets merged, upgrading to 0.2.1 might make this change non-breaking

go-logr/logr#20

@RafalSkolasinski RafalSkolasinski mentioned this pull request Jul 9, 2020
Closed
19 tasks
@adriangonz adriangonz mentioned this pull request Jul 10, 2020
Closed
@abursavich abursavich mentioned this pull request Jul 18, 2020
Closed
@micnncim
Copy link
Contributor Author

dup: #1011

@micnncim micnncim closed this Jul 29, 2020
@micnncim micnncim deleted the logr-v0.2.0 branch July 29, 2020 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alenkacz alenkacz Awaiting requested review from alenkacz

@vincepri vincepri Awaiting requested review from vincepri

Assignees

@gerred gerred

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@micnncim @k8s-ci-robot @vincepri @justenwalker @gerred